Repository navigation
fix(hao): registration confirm/modify flow, global demographics bar, closure dialogs - #101
Closed
Aarti-panchal01 wants to merge 3 commits into
Closed
Aarti-panchal01 wants to merge 3 commits into
Aarti-panchal01 wants to merge 3 commits into
Conversation
Legacy's Material dialogs color-code their header by status (blue Info for confirm prompts, green Success for save/close/transfer results) and its closure screen's Transfer Call / Submit & Continue / Submit & Close buttons are green. Our dialogs rendered a plain neutral header and the closure buttons used the default outline style, losing that signal. - Common-UI: dialog gets an optional `zStatus` (info/success/error) that renders a colored full-bleed title banner using the app's existing design tokens; omitted keeps every other call site's neutral header. - ConfirmDialogService: `confirm()`/`alert()` pass through a new `status` option to `zStatus`. - HAO closure: confirm prompts (proceed to closure, cancel, submit close/continue, transfer) are tagged `status: 'info'`; error alerts `status: 'error'`; and the close/transfer success paths now show a green "Success" alert (legacy's `callClosedSuccessfully` / `callTransferredTo <campaign>`) before handing off, which today silently skip straight to navigation with no confirmation at all. - HAO case-sheet save success/error alerts get the matching success/error status and title. - Closure screen's Transfer Call / Submit & Continue / Submit & Close buttons render green (existing `--success` tokens), matching legacy. Verified live: green Success banner on case-sheet save and on close/transfer, blue Info banner on closure confirm prompts, green closure action buttons. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Selecting an existing beneficiary now fetches the full record (beneficiary/searchUserByID) and opens the same registration form pre-filled for review/edit (personal details -> Next -> address, full state/district/sub-district/village cascade), instead of jumping straight into the workspace with no confirm step. Adds "Modify" (beneficiary/update, green) alongside "Proceed" (blue), matching legacy's Back/Modify/Proceed-to-HAO pattern. - CallStore: CallerDemographics carries the fuller record (display id, state/district/sub-district/village names, marital status, category, caste, education) needed for the summary bar and the confirm screen. - innerpage shell: renders the beneficiary summary bar (name, reg id, gender, age, state, district, sub-district, village, marital status, category, caste, and CO-only education) persistently across every on-call screen, matching legacy's `innerpage.component.html` shell. - HAO Provide Service: removed the SMS tab, which doesn't exist in legacy (legacy sends an SMS as a case-sheet-save side effect, not a screen of its own). Note: the Provisional Diagnosis chief-complaint-fallback fix from the same live-verification round is NOT included here — this branch's case-sheet still uses the pre-redesign disease-picklist version of that field (an unmerged prior PR changed it to the readonly synced-text field this fallback targets), so there is nothing to attach it to yet. Verified live end-to-end on the combined local branch: select existing beneficiary -> full personal + address prefill with correctly cascaded dropdowns -> Proceed -> HAO workspace shows the summary bar globally; only Health Advisory / Diabetic Screening / BP Screening tabs remain. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…dialogs Same zStatus mechanism this branch already introduces for HAO; MO/CO/Counsellor share RoleWorkspaceComponent and were missed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Legacy/current-app parity fixes for the HAO inbound flow found by re-comparing the running app against the actual legacy screens/source this round:
Closure & dialogs
callClosedSuccessfully/callTransferredTo <campaign>) — today both paths silently skip straight to navigation with no confirmation at all.--successdesign tokens.Registration flow
beneficiary/searchUserByID) and opens the same registration form pre-filled for review/edit (personal details → Next → address, with the full state/district/sub-district/village cascade) instead of jumping straight into the workspace with no confirm step. Adds "Modify" (beneficiary/update, green) alongside "Proceed" (blue), matching legacy's Back/Modify/Proceed-to-HAO pattern.innerpage.component.htmlshell — previously it only appeared inline on the case-sheet card.Dependency
Requires PSMRI/Common-UI#88 (adds the optional
zStatusfield the dialog renders on). This branch's submodule pointer already targets that PR's commit; merge Common-UI#88 first (or alongside).Not included here
The Provisional Diagnosis chief-complaint-fallback fix (readonly field defaults to the complaint text when empty, matching legacy's
psd = pcc.trim()) is not in this PR — this branch's case-sheet still uses the pre-redesign disease-picklist version of that field; an unmerged prior PR changes it to the readonly synced-text field this fix targets. It's verified working on the local combined branch and will follow once that redesign lands.Why
Continuing HAO/legacy visual-parity work from live-comparison testing against the real legacy app, scoped to HAO only for this round.
Test plan
tsc --noEmit(against tsconfig.app.json) clean, production build clean🤖 Generated with Claude Code