Skip to content

fix(hao): registration confirm/modify flow, global demographics bar, closure dialogs - #101

Closed
Aarti-panchal01 wants to merge 3 commits into
mainfrom
fix/hao-closure-status-dialogs
Closed

Aarti-panchal01 wants to merge 3 commits into
mainfrom
fix/hao-closure-status-dialogs

Conversation

@Aarti-panchal01

@Aarti-panchal01 Aarti-panchal01 commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Legacy/current-app parity fixes for the HAO inbound flow found by re-comparing the running app against the actual legacy screens/source this round:

Closure & dialogs

  • Closure confirm prompts (proceed to closure, cancel, submit close/continue, transfer) render with a blue "Info" header; error alerts with a red "Error" header.
  • Closing or transferring a call now shows a green "Success" alert first (legacy's callClosedSuccessfully / callTransferredTo <campaign>) — today both paths silently skip straight to navigation with no confirmation at all.
  • HAO case-sheet save success/error alerts get the matching green/red status and title.
  • Closure screen's Transfer Call / Submit & Continue / Submit & Close buttons render green, using the app's existing --success design tokens.

Registration flow

  • Selecting an existing beneficiary now fetches the full record (beneficiary/searchUserByID) and opens the same registration form pre-filled for review/edit (personal details → Next → address, with the full state/district/sub-district/village cascade) instead of jumping straight into the workspace with no confirm step. Adds "Modify" (beneficiary/update, green) alongside "Proceed" (blue), matching legacy's Back/Modify/Proceed-to-HAO pattern.
  • The beneficiary summary bar (name, reg id, gender, age, state, district, sub-district, village, marital status, category, caste, and — CO only — education) now renders persistently across every on-call screen, matching legacy's innerpage.component.html shell — previously it only appeared inline on the case-sheet card.
  • Removed the HAO "SMS" service tab, which doesn't exist in legacy (legacy sends an SMS as a side effect of saving the case sheet, not a screen of its own).

Dependency

Requires PSMRI/Common-UI#88 (adds the optional zStatus field the dialog renders on). This branch's submodule pointer already targets that PR's commit; merge Common-UI#88 first (or alongside).

Not included here

The Provisional Diagnosis chief-complaint-fallback fix (readonly field defaults to the complaint text when empty, matching legacy's psd = pcc.trim()) is not in this PR — this branch's case-sheet still uses the pre-redesign disease-picklist version of that field; an unmerged prior PR changes it to the readonly synced-text field this fix targets. It's verified working on the local combined branch and will follow once that redesign lands.

Why

Continuing HAO/legacy visual-parity work from live-comparison testing against the real legacy app, scoped to HAO only for this round.

Test plan

  • tsc --noEmit (against tsconfig.app.json) clean, production build clean
  • Verified live end-to-end: select existing beneficiary → full personal + address prefill with correctly cascaded dropdowns → Proceed → HAO workspace shows the summary bar globally; green "Success" banner on case-sheet save, blue "Info" banner on closure confirm prompts, green "Success" banner + navigation on Submit & Close, green closure action buttons; only Health Advisory / Diabetic Screening / BP Screening tabs remain

🤖 Generated with Claude Code

Legacy's Material dialogs color-code their header by status (blue Info
for confirm prompts, green Success for save/close/transfer results) and
its closure screen's Transfer Call / Submit & Continue / Submit & Close
buttons are green. Our dialogs rendered a plain neutral header and the
closure buttons used the default outline style, losing that signal.

- Common-UI: dialog gets an optional `zStatus` (info/success/error) that
  renders a colored full-bleed title banner using the app's existing
  design tokens; omitted keeps every other call site's neutral header.
- ConfirmDialogService: `confirm()`/`alert()` pass through a new
  `status` option to `zStatus`.
- HAO closure: confirm prompts (proceed to closure, cancel, submit
  close/continue, transfer) are tagged `status: 'info'`; error alerts
  `status: 'error'`; and the close/transfer success paths now show a
  green "Success" alert (legacy's `callClosedSuccessfully` /
  `callTransferredTo <campaign>`) before handing off, which today
  silently skip straight to navigation with no confirmation at all.
- HAO case-sheet save success/error alerts get the matching
  success/error status and title.
- Closure screen's Transfer Call / Submit & Continue / Submit & Close
  buttons render green (existing `--success` tokens), matching legacy.

Verified live: green Success banner on case-sheet save and on
close/transfer, blue Info banner on closure confirm prompts, green
closure action buttons.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4c125c10-ba91-4981-aef9-d12d49a922e8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- Selecting an existing beneficiary now fetches the full record
  (beneficiary/searchUserByID) and opens the same registration form
  pre-filled for review/edit (personal details -> Next -> address, full
  state/district/sub-district/village cascade), instead of jumping
  straight into the workspace with no confirm step. Adds "Modify"
  (beneficiary/update, green) alongside "Proceed" (blue), matching
  legacy's Back/Modify/Proceed-to-HAO pattern.
- CallStore: CallerDemographics carries the fuller record (display id,
  state/district/sub-district/village names, marital status, category,
  caste, education) needed for the summary bar and the confirm screen.
- innerpage shell: renders the beneficiary summary bar (name, reg id,
  gender, age, state, district, sub-district, village, marital status,
  category, caste, and CO-only education) persistently across every
  on-call screen, matching legacy's `innerpage.component.html` shell.
- HAO Provide Service: removed the SMS tab, which doesn't exist in
  legacy (legacy sends an SMS as a case-sheet-save side effect, not a
  screen of its own).

Note: the Provisional Diagnosis chief-complaint-fallback fix from the
same live-verification round is NOT included here — this branch's
case-sheet still uses the pre-redesign disease-picklist version of that
field (an unmerged prior PR changed it to the readonly synced-text
field this fallback targets), so there is nothing to attach it to yet.

Verified live end-to-end on the combined local branch: select existing
beneficiary -> full personal + address prefill with correctly cascaded
dropdowns -> Proceed -> HAO workspace shows the summary bar globally;
only Health Advisory / Diabetic Screening / BP Screening tabs remain.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Aarti-panchal01 Aarti-panchal01 changed the title fix(hao): color-code closure dialogs and buttons to match legacy fix(hao): registration confirm/modify flow, global demographics bar, closure dialogs Sep 9, 2026
…dialogs

Same zStatus mechanism this branch already introduces for HAO; MO/CO/Counsellor share RoleWorkspaceComponent and were missed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Aarti-panchal01

Copy link
Copy Markdown
Member Author

Superseded by #103 — both implement the identical beneficiary-edit feature and identical innerpage.component.ts changes. #103 was chosen as the target since it also carries the ABHA search field-routing fix. Closing in favor of #103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant