Skip to content

fix(dialog): order the footer Ok-first and centre it, matching legacy AMRIT #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aarti-panchal01 wants to merge 2 commits into
base: angular-zard-migration
Choose a base branch
from
Open

fix(dialog): order the footer Ok-first and centre it, matching legacy AMRIT #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7dae6
fix(dialog): order the footer Ok-first and centre it, matching legacy…
Aarti-panchal01 Sep 11, 2026
9744bb2
fix(dialog): drop the footer-order code comment
Aarti-panchal01 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions v2/ui/dialog/dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,7 @@ export class ZardDialogOptions<T, U> {
</main>

@if (!config.zHideFooter) {
<footer class="flex flex-col-reverse gap-2 sm:flex-row sm:justify-end sm:gap-0 sm:space-x-2">
@if (config.zCancelText !== null) {
<button type="button" data-testid="z-cancel-button" z-button zType="outline" (click)="onCloseClick()">
@if (config.zCancelIcon) {
<ng-icon [svg]="config.zCancelIcon" class="size-4!" />
}

{{ config.zCancelText ?? 'Cancel' }}
</button>
}

<footer class="flex flex-col gap-2 sm:flex-row sm:justify-center sm:gap-3">
@if (config.zOkText !== null) {
<button
type="button"
Expand All @@ -143,6 +133,16 @@ export class ZardDialogOptions<T, U> {
{{ config.zOkText ?? 'OK' }}
</button>
}

@if (config.zCancelText !== null) {
<button type="button" data-testid="z-cancel-button" z-button zType="outline" (click)="onCloseClick()">
@if (config.zCancelIcon) {
<ng-icon [svg]="config.zCancelIcon" class="size-4!" />
}

{{ config.zCancelText ?? 'Cancel' }}
</button>
}
</footer>
}
`,
Expand Down