Skip to content

feat(AMM-2496): Stop TB team (van) on Work Location Mapping and faster Nikshay lookups - #155

Merged
SauravBizbRolly merged 6 commits into
release-3.12.0from
vb/stoptb-bulk-upload-fixes
Oct 21, 2026
Merged

feat(AMM-2496): Stop TB team (van) on Work Location Mapping and faster Nikshay lookups#155
SauravBizbRolly merged 6 commits into
release-3.12.0from
vb/stoptb-bulk-upload-fixes

Merge origin/release-3.12.0 into vb/stoptb-bulk-upload-fixes

46e4bd5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 21, 2026 in 37s

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 129 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using a dynamically formatted SQL query is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48e&open=AaFcqdgFwC_RT7R0M48e&pullRequest=155

Check warning on line 154 in src/main/java/com/iemr/admin/controller/nikshay/NikshayLocationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdeKwC_RT7R0M48W&open=AaFcqdeKwC_RT7R0M48W&pullRequest=155

Check failure on line 111 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "providerServiceMapID" 4 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48Y&open=AaFcqdgFwC_RT7R0M48Y&pullRequest=155

Check failure on line 105 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "vanID" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48Z&open=AaFcqdgFwC_RT7R0M48Z&pullRequest=155

Check warning on line 123 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using a dynamically formatted SQL query is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48d&open=AaFcqdgFwC_RT7R0M48d&pullRequest=155

Check warning on line 104 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using a dynamically formatted SQL query is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48b&open=AaFcqdgFwC_RT7R0M48b&pullRequest=155

Check warning on line 116 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using a dynamically formatted SQL query is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48c&open=AaFcqdgFwC_RT7R0M48c&pullRequest=155

Check failure on line 55 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " AND " 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48X&open=AaFcqdgFwC_RT7R0M48X&pullRequest=155

Check warning on line 44 in src/main/java/com/iemr/admin/service/stoptbteam/StopTBTeamService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdXNwC_RT7R0M48Q&open=AaFcqdXNwC_RT7R0M48Q&pullRequest=155

Check warning on line 46 in src/main/java/com/iemr/admin/controller/stoptbteam/StopTBTeamController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdcgwC_RT7R0M48R&open=AaFcqdcgwC_RT7R0M48R&pullRequest=155

Check warning on line 124 in src/main/java/com/iemr/admin/controller/nikshay/NikshayLocationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdeKwC_RT7R0M48U&open=AaFcqdeKwC_RT7R0M48U&pullRequest=155

Check failure on line 175 in src/main/java/com/iemr/admin/controller/nikshay/NikshayLocationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "nikshayTUID" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdeKwC_RT7R0M48S&open=AaFcqdeKwC_RT7R0M48S&pullRequest=155

Check warning on line 139 in src/main/java/com/iemr/admin/controller/nikshay/NikshayLocationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdeKwC_RT7R0M48V&open=AaFcqdeKwC_RT7R0M48V&pullRequest=155

Check failure on line 176 in src/main/java/com/iemr/admin/controller/nikshay/NikshayLocationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "nikshayFacilityID" 3 times. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdeKwC_RT7R0M48T&open=AaFcqdeKwC_RT7R0M48T&pullRequest=155

Check warning on line 97 in src/main/java/com/iemr/admin/repository/stoptbteam/StopTBTeamRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using a dynamically formatted SQL query is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_Admin-API&issues=AaFcqdgFwC_RT7R0M48a&open=AaFcqdgFwC_RT7R0M48a&pullRequest=155
View more details on SonarQubeCloud