Repository navigation
feat: track sample counts in hierarchical stats - #56
Merged
Merged
Conversation
HierarchicalStats nodes now carry a samples attribute that counts the samples contributing to their total, so that aggregated metrics can be reported together with the number of samples backing them.
P403n1x87
force-pushed
the
feat/stats-sample-count
branch
from
October 9, 2026 11:43
116435e to
79f01c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 78.21% 78.08% -0.13%
==========================================
Files 20 20
Lines 1983 1985 +2
Branches 245 245
==========================================
- Hits 1551 1550 -1
- Misses 357 360 +3
Partials 75 75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HierarchicalStatsnodes now have asamplesattribute that counts the samples contributing to the node'stotal.AustinStats.updatesets it to 1 on each new node, and__lshift__adds it up when merging, the same wayownandtotalare merged.This lets aggregated metrics be reported along with the number of samples behind them. It's groundwork for an upcoming query API on top of
AustinStats.The field defaults to
0, so existing code that builds stats objects keeps working. Tests that compare wholeAustinStatsobjects now include the expected counts.