Repository navigation
Remove the Slither and Snyk CI jobs - #3018
Merged
Merged
Conversation
Neither job ever blocks a merge: master has no required checks and Snyk runs with continue-on-error. Slither has passed on every recent PR, its last fixes only added slither-disable comments to core contracts, and its install downloads an unused solc 0.8.7 plus an unpinned slither. - drop both jobs from foundry.yml - delete slither.config.json and slither.db.json and the pnpm scripts - remove the Slither sections from the README and the deploy docs - keep the slither-disable comments in contracts/ to leave them untouched
shahthepro
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Slither and Snyk jobs from CI. Both cost maintenance and block nothing.
Slither
masterhas no required status checks.slither-disablecomments toVaultAdminandVaultStorage. The tool made us touch core contracts to silence it.slither-analyzerunpinned.slither.config.jsonexcludedVaultInitializerandStableMathfrom analysis anyway.solidity-auditorskill and Hypernative remain.Snyk
continue-on-error: true, so it can never fail a PR. Its results only reach the Snyk dashboard.pnpm-workspace.yaml(minimumReleaseAge: 10080, i.e. 7 days).Code Change
.github/workflows/foundry.yml: drop theslitherandsnykjobs. The 10 remaining jobs are unchanged.contracts/slither.config.jsonandcontracts/slither.db.json(118 triage entries, 497 KB).slitherandslither:triagepnpm scripts.contracts/README.mdand the CI row fromscripts/deploy/ARCHITECTURE.md.slither-disablecomments incontracts/contracts/are deliberately kept, so no contract source changes.Snyk is currently the only dependency scanner on this repo. In this repo's settings, the Dependency graph is disabled and Dependabot alerts are inactive. The 53 "vulnerabilities" GitHub shows on push are frozen alerts on
yarn.lockfiles that were deleted on 2026-09-08 (#2998).An admin should enable, under Settings → Code security:
Both are free. Once they are on, the stale alerts should resolve against the current
pnpm-lock.yamlfiles.After merge, the
SNYK_TOKENrepo secret and the Snyk project can be deleted.Testing
slither/snykoutside the keptslither-disablecomments and the embedded sources indeployments/*.jsonmetadata.🤖 Generated with Claude Code