Repository navigation
Conversation
V1 reports which LiveIntent-provided EIDs reached each bidder; V2 did not. Match on the full EID list before the dedupe by source, the same input V1 uses, so a same-source Optable EID can't hide a LiveIntent one.
mosherBT
requested review from
alexandretrendel-optable and
etiennelatendresse-optable
and removed request for
alexandretrendel-optable
October 9, 2026 17:57
1 of 4 tasks
Comment on lines
400
to
402
| const optableEIDS = eids.filter((e: { inserter: string }) => e.inserter === "optable.co"); | ||
| const optableMatchers = [...new Set(optableEIDS.map((e: any) => e.matcher).filter(Boolean))]; | ||
| const optableSources = [...new Set(optableEIDS.map((e: any) => e.source).filter(Boolean))]; |
Contributor
There was a problem hiding this comment.
Pre-existing, but same issue as the LiveIntent fix below. If the optable uidapi.com EID comes before liveintent, optableSources loses the source and optableMatchers loses the matcher. Thats because the map above is keyed by source alone
antoinehakim-optable
approved these changes
Oct 9, 2026
etiennelatendresse-optable
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
V2 (
lib/addons/prebid/analytics.ts) doesn't report LiveIntent EIDs, which V1 does. One of the parity gaps blocking the V1/V2 merge.What Changed
toWitness: per bidder request,hasLiEidsandliSources(EIDs with auids[].ext.provider === "liveintent.com"); top level,liveintentEIDs(union ofliSources).user.ext.eids+user.eidsbefore the dedupe bysource, same input as V1.How to Test
toWitnesscases: LiveIntent present, absent, and mixed with Optable EIDs (including a LiveIntent EID that the source dedupe would drop)Notes
Uses V1's current rule. analytics: report IntentIQ, GrowthCode and TransUnion EID presence, catch LiveIntent's main ID #357 widens V1's LiveIntent match (
source === "liveintent.com") and adds IntentIQ/GrowthCode/TransUnion; V2 needs a follow-up once that merges.Breaking change
Requires release