Repository navigation
analytics: V1 auction with Optable sources is not missed - #360
Closed
MO-Thibault wants to merge 1 commit into
Closed
MO-Thibault wants to merge 1 commit into
MO-Thibault wants to merge 1 commit into
Conversation
Same fix as Optable#356, applied to the V1 add-on that feeds bid_analytics. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Folded into #356 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as #356, applied to the V1 add-on (
lib/addons/prototypes/analytics.js), which is the one that sendsauction_processedand feedsbid_analytics. #356 changes V2 only.V1 flags an auction
missedwhen it completed before the analytics hook attached, regardless of whether Optable EIDs were already on the bid requests. When the wrapper reads the EID cache before the hook attaches, the auction is enriched but still reported as missed. The payload now sendsmissed: missed && optableSources.length === 0, using the auction-level union already built foroptableSources.missedV1 has no
optableLoadedfield, so unlike #356 there is no second field to keep tied to hook timing.Downstream
Historical rows can be corrected in SQL with
missed AND ARRAY_LENGTH(auction_struct.optableSources) = 0; the same expression is correct for rows emitted after this change.Overlap
#351 adds
lib/addons/prototypes/analytics.test.js. The tests here are in a separate file,analytics.missed.test.js, so the two PRs do not conflict on tests. The one-line change sits inwitnessData, which #351 and #357 also edit; whichever merges later needs a trivial rebase.Test plan
lib/addons/prototypes/analytics.missed.test.js: the three cases abovepnpm exec jest: 30 suites, 526 tests passprettier --checkclean on both files🤖 Generated with Claude Code