Skip to content

fix(gesture): prevent layout gesture reset crashes - #1085

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/ios_gesture_crash
Sep 15, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
bugfix/ios_gesture_crash

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Prevent crashes when lazy gesture debug data reads child state during a reset.
  • Reset a local child value before writing it back in terminal, reset-seed, and child-removal paths.
  • Add regression coverage for all three reset paths and preserved terminal debug snapshots.

Closes #1086

@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. impact: crash Crash, assertion, or fatal runtime failure. type: bug Something is not working correctly. labels Sep 15, 2026
@tuist

tuist Bot commented Sep 15, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1225 0 1225 02076d961

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 55.2s 02076d961

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.22%. Comparing base (dbd2dfb) to head (d750029).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   28.21%   28.22%   +0.01%     
==========================================
  Files         749      749              
  Lines       55199    55207       +8     
==========================================
+ Hits        15573    15584      +11     
+ Misses      39626    39623       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 37385fb into main Sep 15, 2026
6 of 8 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/ios_gesture_crash branch September 15, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. impact: crash Crash, assertion, or fatal runtime failure. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layout gesture reset crashes when gesture debugging is enabled

1 participant