Skip to content

save_plot closes the hidden screen Makie's save opens, so plots can be saved and then shown under GLMakie #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1-Bort-1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

save_plot closes the hidden screen Makie's save opens, so plots can be saved and then shown under GLMakie #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c8fb01
save_plot closes the screen Makie's save opened, so a saved figure ca…
1-Bort-1 Sep 30, 2026
b625f4a
GLMakie save-then-show test checks the scene sits on the titled scree…
1-Bort-1 Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/398-plot-functions-throw-under-glmakie-when-.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Under GLMakie, a plot function called with `is_save=true, is_show=true` no longer throws `GLMakie can not display a scene in multiple Screens`: `save_plot` closes the hidden screen the save opened.
4 changes: 4 additions & 0 deletions ext/VortexStepMethodMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,7 @@ function VortexStepMethod.save_plot(fig::Makie.Figure, save_path, title; data_ty
@debug "Attempting to save figure to: $full_path"
@debug "Current working directory: $(pwd())"

screens_before_save = copy(fig.scene.current_screens)
try
save(full_path, fig)
@debug "Figure saved as $data_type"
Expand All @@ -508,6 +509,9 @@ function VortexStepMethod.save_plot(fig::Makie.Figure, save_path, title; data_ty
@error "Error saving figure: $e"
@error "Error type: $(typeof(e))"
rethrow(e)
finally
# GLMakie refuses to show a figure still held by the hidden screen `save` opened.
foreach(close, setdiff(fig.scene.current_screens, screens_before_save))
end
end

Expand Down
16 changes: 16 additions & 0 deletions test/plotting/test_plotting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,22 @@ end
@test isfile(joinpath(save_dir, "Hidden_combined.png"))
end

@testset "a plot saved under GLMakie can then be shown" begin
MakieControlPlots.GLMakie.activate!()
try
fig = plot_distribution([y_coordinates], [results_vsm], ["VSM"];
title="Saved then shown", data_type=".png", save_path=save_dir,
is_save=true, is_show=false)
@test isfile(joinpath(save_dir, "Saved_then_shown.png"))
makie_ext.display_named(fig, "Saved then shown")
@test fig.scene.current_screens == [makie_ext.SCREENS["Saved then shown"]]
finally
screen = pop!(makie_ext.SCREENS, "Saved then shown", nothing)
isnothing(screen) || close(screen)
CairoMakie.activate!()
end
end

@testset "round-off CS plots flat, a varying CS keeps its autoscale" begin
fig = Figure()
ax_noise = Axis(fig[1, 1])
Expand Down
Loading