Remove results dict #94

Activity

1. ufechner7

   added

   enhancementNew feature or requestNew feature or request

   on Mar 4, 2025
2. 1-Bart-1

   added

   performance

   on Mar 4, 2025
3. 1-Bart-1

   added this to the Version 1.2 milestone on Mar 5, 2025
4. ufechner7 commented on Mar 22, 2025

   

   ufechner7

   on Mar 22, 2025

   Member

   More actions

   I would suggest:

   1. remove the first point and put it into a separate issue

   To be discussed: Do we want to have one VSMSolution struct, or two, a small and a large one.

   👍React with 👍1Reacted by Bot van de Lint
5. 1-Bart-1 commented on Mar 22, 2025

   

   1-Bart-1

   on Mar 22, 2025

   Last edited by 1-Bart-1

   MemberAuthor

   More actions

   One big struct for now, we can add a smaller one in a new issue. I marked the first point as done, as you did some great progress there already.

   👍React with 👍1Reacted by Bot van de Lint
6. 1-Bart-1 commented on Mar 22, 2025

   

   1-Bart-1

   on Mar 22, 2025

   Last edited by 1-Bart-1

   MemberAuthor

   More actions

   And for the struct field names: we should stay close to the current dict names. But things like "Fx", "Fy", "Fz" can be combined in one "F" or "force" field.

   👍React with 👍1Reacted by Bot van de Lint
7. ufechner7 commented on Mar 22, 2025

   

   ufechner7

   on Mar 22, 2025

   Last edited by ufechner7

   Member

   More actions

   @1-Bart-1 Can you please create a pull request, just defining the new version of the VSMSolution struct that you suggest? I would then comment there. I think it would be good to have Union{MVec, Nothing} for new fields like a force. Then we could skip calculating these values when we don't need them, for example using a parameter like shortsolution=true for the solve function.

   👍React with 👍1Reacted by Bot van de Lint
8. ufechner7 commented on Mar 22, 2025

   

   ufechner7

   on Mar 22, 2025

   Member

   More actions

   "F" or "force" field

   I prefer lower case names for variables and attributes. CamelCase case should be reserved for types and structs.

   👍React with 👍2Reacted by Bart van de Lint and Bot van de Lint
9. ufechner7

   modified the milestones: Version 1.2, Version 1.3 on Mar 27, 2025
10. 1-Bart-1

    added

    priorityOpen work waits on thisOpen work waits on this

    on Apr 17, 2025
11. 1-Bart-1

    added

    agent:needs-plan-approvalPost a plan and wait for approval before writing any codePost a plan and wait for approval before writing any code

    on Sep 22, 2026
12. 1-Bart-1

    assigned

    1-Bort-1

    on Sep 22, 2026
13. 1-Bort-1

    added

    agent:queuedAgent task stateAgent task state

    on Sep 22, 2026
14. 1-Bort-1 commented on Sep 22, 2026

    

    1-Bort-1

    on Sep 22, 2026

    Last edited by 1-Bort-1

    Member

    More actions

    One PR, as asked: VSMSolution gets every Dict quantity (cl/cd/cs, lift/drag/side, *_distribution, alpha_uncorrected, rey, q_ref, va_ref_vec, span, AR, areas, center of pressure), filled by solve!; plotting, generate_polar_data, examples, docs and tests move onto it; solve() and calculate_results are removed (BREAKING). Benchmarked solve! before/after.
    Built on #389, which rewrites calculate_results and calc_forces!; #391's plot keywords get merged in whichever lands second.
    Leaving out a small results struct and renaming the existing cl_dist/cd_dist.
15. 50 remaining items

    Load more
16. 1-Bort-1

    added

    agent:ciAgent task stateAgent task state

    agent:reviewAgent task stateAgent task state

    agent:queuedAgent task stateAgent task state

    agent:runningAgent task stateAgent task state

    and removed

    agent:ciAgent task stateAgent task state

    agent:reviewAgent task stateAgent task state

    agent:queuedAgent task stateAgent task state

    agent:runningAgent task stateAgent task state

    on Sep 28, 2026