trigger _Any_Active when shock is sent from VRChat

[kekkels]

fix for #72

Summary by CodeRabbit

• Improvements
  • Shock activity and maximum intensity now reflect both remote control logs and active local shockers. When either source reports an active shock, the combined status indicates activity; the reported maximum intensity reflects the highest value across both sources. Cooldown aggregation and individual shocker parameter updates remain unchanged.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 51474df2-4be2-441b-a89a-5fe7ba02fa8a

📥 Commits

Reviewing files that changed from the base of the PR and between 4143ba6 and 7991400.

📒 Files selected for processing (1)

• ShockOsc/Services/OscHandler.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

SendParams now combines remote shock activity and maximum intensity from control logs with values from active local shockers. It sends the combined activity and intensity values.

Changes

Shock activity aggregation

Layer / File(s)	Summary
Combine remote and local shock parameters ShockOsc/Services/OscHandler.cs	GetRemoteAnyActive returns remote activity and maximum intensity without sending OSC updates. SendParams combines those values with local shocker activity and intensity, then sends the combined parameters.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 79914

The change combines remote and local shock activity and intensity. No supported merge-blocking behavior change was identified; it is mergeable subject to normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 79914

The change broadens activity feedback sent to VRChat without adding shock-command authority. After a local stop, the combined activity flag can remain on until the original activity window expires. The effect on external consumers is not established.

Retained concerns

• Low · reliability · observed: The newly combined _Any activity feedback can remain active after a local stop or reset until the recorded shock duration expires, so shared feedback need not reflect the local control transition.

Security review details

Security Blast Radius

• inferred — The demonstrated expansion is local activity becoming visible through the shared OSC output. The evidence does not establish a new path for issuing shock commands.

Trust Boundaries and Controls

• observed — Received OSC actions use local precondition checks on the examined immediate-command path. Remote control logs arrive through a separate subscription; its upstream authorization is not established by the available source.

Resilience and Maintainability Implications

• observed — Remote aggregation counts only unexpired Shock logs. Local aggregation instead follows recorded command duration, which can outlast a subsequent stop in the examined path.

Hardening Proposals

• proposed — If _Any is intended to represent effective control rather than the original command window, align its local inputs with stop, reset, and failed-delivery transitions before relying on it as safety feedback.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: triggering _Any_Active when a shock is sent from VRChat.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}