Repository navigation
Add LearnBitcoin references to Taproot and CoinJoin topics - #972
treib-holdings wants to merge 2 commits into
Conversation
|
@treib-holdings is attempting to deploy a commit to the OpenSats Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
LGTM, but please have a look @TumaBitcoiner since the topic pages are your baby 👶 |
|
Hey @treib-holdings! Thank you so much for your PR! I like the new additions and I think they are valuable "follow-ups" that users can read to learn more. One thing before approving. Would you be so kind to also address this, since you are already working on the topic?
|
The two older references said "Learning Bitcoin" and "Learn Bitcoin"; the site's name is one word, so all four lines now match.
|
Done. The RPC and Dust limit lines now say LearnBitcoin as well, so all four match. |
TumaBitcoiner
left a comment
There was a problem hiding this comment.
LGTM! @dergigi Let's merge!
The RPC and Dust limit pages already cite LearnBitcoin glossary entries. This adds two of the site's long-form chapters to topics where they cover ground the current references don't:
The two existing lines are labeled "Learning Bitcoin" (rpc.mdx) and "Learn Bitcoin" (dust-limit.mdx). The site's name is one word, LearnBitcoin, so that's what the new lines use. I left the old ones alone. If you'd like all four to match, I can change them in this PR.
Disclosure: I run LearnBitcoin. It is CC-BY-SA, no ads, no affiliates, sources on every chapter. Fine to drop either line or reword the labels.
Build Preview: