Repository navigation
RR-20: renderer default baseline records core 0.14.0 examples - #156
Merged
Merged
Conversation
… reverted before merge) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 74c929e0-b425-4be1-a45d-0925f7451fe5) |
Generated in mcr.microsoft.com/playwright:v1.63.0-noble@sha256:eff16c30e6f3f4af0a03fa4b706120d5e9b0891c344a27d64559aff5900a4a27. Evidence (diff.json and the review sheets) is attached to the run: https://github.com/OpenPresentation/opf-render/actions/runs/37606586266. A human reviews the changed slides before approving.
Contributor
|
regenerate-goldens pushed one commit that rewrites only the decks that moved. Review diff.json and the sheets in the run artifacts before approving: https://github.com/OpenPresentation/opf-render/actions/runs/37606586266. CI was dispatched on the new commit. |
golden-override goes back to '' (it only served regenerate-goldens on this branch): the roller must not make the renderer baseline the lock's golden (opf-render#130). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 4f9b3cfb-1d85-4407-8c6f-192357d00b18) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the renderer's DEFAULT golden baseline (
test/golden/opf-examples-png.cover-centering) for the core 0.14 examples (digestd414d352..., 127 decks, 807 slides), the opf-render#131 analogue. Without it the opf-render 0.14.0 publish fails with 'Golden corpus changed'.rel014-baseline-checkvs core'sopf-examples-png.fa-0-14.sha256.json: sourceEqual true, settingsEqual true, 807 entries, changedSlides 0golden-override: ''(the temporary override is reverted in the last commit)🤖 Generated with Claude Code
Note
Low Risk
Fixture-only golden baseline refresh with no production code changes; release-blocking if wrong but validated against core’s reviewed fixture.
Overview
RR-20 bumps the renderer’s default PNG golden baseline (
test/golden/opf-examples-png.cover-centering) from core 0.13.0 examples to core 0.14.0, so publish/CI golden gates match the registry core without “Golden corpus changed” failures._baseline.jsonnow points at examples digestd414d352...(127 decks, 807 slides vs 126/805). 14 deck*.sha256.jsonfiles change: mostly slide #2 hash/byte updates across gallery decks (format-audit / chart example edits in core), plus technical chart fixtures—chart-data-sourcesshrinks to one slide,chart-type-samplergains slide #2, and newchart-highlightgolden manifest is added.No renderer logic changes; hashes were regenerated via
regenerate-goldensand cross-checked against core’s reviewedopf-examples-png.fa-0-14.sha256.json. Addschanges/rr-20-golden-core-0-14-0.mdandtest/golden/notes/RR-20-core-0-14.mddocumenting rationale and verification.Reviewed by Cursor Bugbot for commit 914a9cb. Configure here.