Skip to content

FA-00: reset golden-override after the 0.14 roll - #155

Merged
michaeljgrimm merged 1 commit into
mainfrom
codex/fa-0-14-golden-reset
Oct 7, 2026
Merged

michaeljgrimm merged 1 commit into
mainfrom
codex/fa-0-14-golden-reset

Conversation

@michaeljgrimm

@michaeljgrimm michaeljgrimm commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Draft: lands right after the single 0.14 lock roll (after FA and RR-55 siblings merge), together with OpenPresentation/opf's transitional-golden deletion.

  • ci.yml golden-override (both ecosystem-refs steps) goes back to ''. The roll adopts opf/scripts/fixtures/opf-examples-png.fa-0-14.sha256.json as the lock's golden (the roller's core-fixture adoption), so the lock's golden is now the true FA set and the override is no longer needed.
  • Stacked on codex/fa-0-14-integration (FA: format audit for 0.14 #151); retarget to main once FA: format audit for 0.14 #151 merges.

Depends-On: OpenPresentation/opf#429

🤖 Generated with Claude Code


Note

Low Risk
CI-only configuration that stops overriding the golden baseline; behavior matches the post-roll lock with no application code changes.

Overview
Resets CI golden baselines to the lock after the 0.14 roll lands, so renderer tests no longer pin a transitional core fixture file.

In .github/workflows/ci.yml, both ecosystem-refs steps (package and node-range) change golden-override from opf/scripts/fixtures/opf-examples-png.fa-0-14.sha256.json to an empty string. An empty value means CI uses the golden recorded in ecosystem.lock.json (now the adopted FA 0.14 set from the roller) instead of the temporary override used during integration.

Reviewed by Cursor Bugbot for commit 9495df8. Configure here.

@michaeljgrimm
michaeljgrimm changed the base branch from codex/fa-0-14-integration to main October 7, 2026 05:23
The roll adopts opf/scripts/fixtures/opf-examples-png.fa-0-14.sha256.json as the
lock's golden, so ci.yml goes back to '' (the lock's golden).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michaeljgrimm
michaeljgrimm force-pushed the codex/fa-0-14-golden-reset branch from 68d57a8 to 9495df8 Compare October 7, 2026 05:23
@michaeljgrimm
michaeljgrimm marked this pull request as ready for review October 7, 2026 07:11
@cursor

cursor Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: b2556cb6-837e-4103-a0df-2ea30a8b6249)

@michaeljgrimm
michaeljgrimm merged commit 03391e6 into main Oct 7, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant