Improve f_check when assembly has no vendor identity - #6003
Open
jczhang07 wants to merge 1 commit into
Open
Conversation
Vendor detection in f_check greps the probe assembly (ftest.s) for a compiler identity string. Some compilers, notably Intel ifx, emit no such string, so the primary `case "$data"` scan fails to set a vendor. The name-based fallback only recognizes bare compiler names, so an ifx-backed wrapper (e.g. mpif90, mpifort or the Cray ftn wrapper) is not matched either, leaving the vendor empty and resulting in a false conclusion that no Fortran compilers are available. Append the output of `$compiler --version` to $data so such compilers are identified by their version banner (ifx's contains "ifx", "Intel").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor detection in f_check greps the probe assembly (ftest.s) for a compiler identity string. Some compilers, notably Intel ifx, emit no such string, so the primary
case "$data"scan fails to set a vendor.The name-based fallback only recognizes bare compiler names, so an ifx-backed wrapper (e.g. mpif90, mpifort or the Cray ftn wrapper) is not matched either, leaving the vendor empty and resulting in a false conclusion that no Fortran compilers are available.
Append the output of
$compiler --versionto $data so such compilers are identified by their version banner (ifx's contains "ifx", "Intel").