Repository navigation
feat(admin): manage OpenMapX instances through the admin panel - #692
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Honor host backup retention, recover migration jobs at startup, preserve attachment bytes after uncertain commits, and retain service and backup request identity across retries. Adapt coordinator bookkeeping without changing its signed provenance or recovery authority. Remove unused catalog stubs and exports, share cache namespace parsing, handle unavailable preview storage, and clarify operator documentation.
…/admin-instance-management-parity
Medformatik
marked this pull request as ready for review
November 5, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The administration panel previously exposed incomplete host operations and left routine instance management to the CLI. This brings supported administration into the UI, with durable jobs and recovery before expanding coverage.
Initial host installation, offline control-plane recovery and destructive whole-stack shutdown remain documented host operations.
Verification
Release and upgrade impact
Product impact: breaking, migration, operator-action
Apply the normal API migrations and upgrade the control services together. Preserve original installation keys and unresolved job records. Private host-control directory prerequisites and reserved community configuration names are documented in the release fragments. Changesets cover the public extension contracts and rebuilt extension CLI.
Review and size
Earlier focused reviews found seven defects in recovery, result truthfulness, receipt bounds and UI ownership; those were fixed. Two additional independent source reviews identified four validated important issues: ignored host backup retention, attachment cleanup after uncertain database commits, duplicate service-action admission, and missing migration/credential startup recovery. Those are now fixed with focused real PostgreSQL, serialized API, agent and UI regressions. A reported log-follow cancellation gap was already handled by the shared helper and its existing disconnect test; no redundant cancellation mechanism was added.
Removed throwing catalog-write stubs, a test-only alias, an unused publication wrapper and four internal-only exports. Shared cache namespace parsing, guarded optional browser metadata storage, and clarified session/link lifetimes and migration naming. Two optional recovery-helper refactors were excluded after a timing-sensitive workflow failed qualification; original async ordering and proof helpers remain.
The correction batch has 40 focused PostgreSQL, 103 web and 104 route cases passing, plus actual guarded Apply/Update and a nonempty credential continuation. Affected types, lint, dead-code and generator checks pass at the recorded sources. Broader local runs were interrupted and are not claimed as passes. Use the latest exact-head hosted CI/CodeQL results for current full-matrix status.
These source reviews sampled the large coordination layer; they do not establish complete protocol correctness or minimality. Live archive-parser duplication, broader legacy request-admission consistency and structural protocol consolidation remain explicit follow-up risks. This remains a draft for human review because of its breadth.
About 57% of the original added lines were generated outputs and 17% were tests/fixtures. There is still substantial handwritten control-plane code; generation alone does not justify the size. New account/privacy SDK types now stay in their family files, removing 607 generated model files and2,434 net lines. Existing client layouts are preserved. Generated SDK/OpenAPI/snapshot output is collapsed by GitHub attributes; handwritten code and SQL remain reviewable.
Suggested review order: canonical contracts/routes → desired-save and recovery boundaries in
prospective-configuration.ts→ core authority/target leases/retention → artifact/integration transactions → account/privacy enforcement → UI job outcomes. The largest owner files remain explicit review hotspots.Current-main integration preserves auth security updates, OSM metadata and system-Back dialogs. A PostgreSQL upgrade regression verifies that installations already on current main receive the administration migrations; existing SQL bytes are preserved. Generic legacy-job cleanup excludes proof-owned durable receipts.
Fresh browser inspection could not run because the browser access host is unavailable; the affected rendered component interactions pass. No screenshots are included. Fresh browser inspection and live external delivery remain separate acceptance limits.