Repository navigation
fix(navigation): retire experimental junction previews - #442
Merged
Merged
Conversation
Medformatik
force-pushed
the
fix/junction-photo-rendering-and-position
branch
2 times, most recently
from
October 11, 2026 07:45
31590fa to
de30954
Compare
Medformatik
marked this pull request as draft
October 11, 2026 11:15
Medformatik
force-pushed
the
fix/junction-photo-rendering-and-position
branch
from
November 5, 2026 00:15
e5043dc to
45fac4b
Compare
Medformatik
marked this pull request as ready for review
November 5, 2026 00:16
Medformatik
force-pushed
the
fix/junction-photo-rendering-and-position
branch
2 times, most recently
from
November 5, 2026 00:32
a77431d to
627e1a8
Compare
Medformatik
force-pushed
the
fix/junction-photo-rendering-and-position
branch
from
November 5, 2026 00:45
627e1a8 to
791df2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the experimental junction previews. Navigation keeps its maneuver instructions, route shields, exit labels and lane arrows in the green panel. The ordinary street-level imagery viewer and its providers remain available.
We explored additional destination boards, schematic junction drawings and lane guidance projected onto approach photos. Fixing image rendering and maneuver positions helped, but reliable guidance required more than a plausible projection: archived images could show a different carriageway or a separated ramp, and camera pose, road layout and lane correspondence were often uncertain. A calibrated example did not establish reliable general coverage. The extra displays could therefore contradict or confuse the useful maneuver guidance.
The decision is to retire the feature and delete its experimental stack. This PR deletes the lower panels, navigation-specific photo acquisition/preparation and overlay code, worker/build wiring, settings, translations, photo fixtures and evaluation tooling. Restoration would need a new evidence-based design.
The useful work remains:
The branch is squashed to one signed commit on current main. There is no migration or new toggle; the retired settings cease to have an effect.
Comparable renders of the actual navigation components use a controlled synthetic example, the application theme and bundled font. They demonstrate the UI removal; they are not a full map replay or a device driving test.
Validation: the full portable suite passed serially: 24,874 passed, 277 skipped (
RAYON_NUM_THREADS=4 pnpm test --maxWorkers=1, under the shared test lock). The standard parallel run hit unrelated generator time limits; the isolated four-test generator suite passed. Lint, all 32 workspace type tasks, policy, OpenAPI and dead-code checks passed before rebasing.Main advanced with Android Auto during that run. After rebasing, all 1,217 focused navigation/car tests passed, and affected core, web and mobile types and dead-code checks passed. The shared phone/car lane presenter retains the new main behavior and evidence-source checks. The final lane-display cleanup passed 284 focused navigation/car tests and affected core, web and mobile type checks.
The rendered examples have no horizontal overflow or browser page errors. Final self-review and an independent code review covered retirement completeness, retained navigation behavior and unintended changes; review regressions were reproduced and fixed before publication. Database-backed checks, native-device driving and deployment were not performed.
Release and upgrade impact
Product impact: breaking
The additional junction previews and their settings are removed. No operator action or data migration is required; the green maneuver guidance and ordinary imagery viewer remain available. Product release information is recorded in
release-notes/retire-junction-previews.md. The navigation implementation lives in private workspaces. A patch Changeset covers the extension CLI because its conservative bundled-workspace dependency graph includes this code; its commands and shipped templates are unchanged.