Repository navigation
[#232] Add the missing OpenIDM and OpenICF Open Graph images - #244
Merged
Merged
Conversation
Six OpenIDM posts reference assets/img/openidm-og.png, which did not exist, so their og:image, twitter:image and BlogPosting image returned 404. Generate it from openidm-logo.png in the same format as the other product images: 1024x512, white background, logo 921 px wide, centered. Fixes OpenIdentityPlatform#232
Generate assets/img/openicf-og.png from openicf-logo.png in the same format as the other product images, and point all 13 OpenICF posts at it: 10 used the bare logo, 3 had no imageurl and fell back to the GitHub avatar.
vharseko
changed the title
vharseko
requested review from
maximthomas
and removed request for
maximthomas
September 30, 2026 18:24
This was referenced Sep 30, 2026
maximthomas
approved these changes
Oct 1, 2026
maximthomas
left a comment
maximthomas
left a comment
Contributor
There was a problem hiding this comment.
praise: The fix lands exactly where the 404 was, and the new cards match the existing ones.
- Every OpenIDM/OpenICF card
imageurlat the head resolves: 6×openidm-og.png, 13×openicf-og.png, both present inassets/img/; the three newimageurl:lines sit inside front matter (line 7 of_posts/2025-07-16-openicf-1-8-0-released.md,_posts/2025-11-13-openicf-2-0-1-released.md,_posts/2026-06-14-openicf-2-0-3-released.md). openidm-og.pngandopenicf-og.pngare 1024×512, 8-bit RGBA with alpha 255 everywhere — the same format asopenam-og.png.git merge-treeof 665455d against each head of #239–#243 is clean.
vharseko
added a commit
that referenced
this pull request
Oct 1, 2026
## Summary > **Merge after #244** — 20 OpenIDM posts point at `openidm-og.png`, which #244 adds. - **Logo strip → OG card (28 posts)** — `imageurl` switched from the ~700×172 `*-logo.png` to the matching 1024×512 `*-og.png`: OpenIDM 12, OpenDJ 9, OpenAM 6, OpenIG 1. - **Product posts without an image (21 posts)** — each gets its product's card: the first entry of `products:`, or the product in the file name for posts without `products:` (OpenAM JEE agents, OpenIDM 7.0.1 / 7.1.0). - **General articles (6 posts)** — a new `assets/img/oip-og.png`, built from `oip-star.png` on a white 1024×512 canvas, for `stateless-vs-stateful-authentication`, `adaptive-authentication`, `passwordless-authentication-methods`, `sso-seamless-authentication-enterprise-client-services`, `llm-in-access-management` and `how-to-auth-via-esia`. - **ESIA article title** — `landing-title` / `landing-title2` had the home page's "Welcome to Open Identity Platform Community" copied into them; they now use the article's own heading, "Аутентификация через госуслуги (ЕСИА)". With #239 this also becomes the page `<title>`. Left to other PRs, as noted in the issue: the OpenICF posts (#244), the redirect `… copy.md` (#242) and the empty `imageurl: ''` (#239). Fixes #245 ## Verification Built the site with `bundle exec jekyll build` (Ruby 3.1, as in CI) and ran the workflow's `htmlproofer` internal-link check: no errors. `og:image` across the built posts: `openam-og.png` 85, `opendj-og.png` 44, `openig-og.png` 24, `openidm-og.png` 20, `oip-og.png` 6. The rest are exactly the posts handled elsewhere: 10 `openicf-logo.png` + 3 GitHub avatar (OpenICF, #244) and 1 empty value (#239). On this branch alone `openidm-og.png` does not exist yet — hence the merge order above. `git merge-tree` against the branches of #239–#244: no conflicts. ## Preview 
vharseko
added a commit
that referenced
this pull request
Oct 2, 2026
…are links (#242) ## Summary Cleanups from #238: - **Unused data file** — deleted `_data/blogposts.yml` (778 lines). Nothing references it: no template, page or `migrate-to-posts.py`; it predates the move to `_posts/` (#227). - **Stray redirect post** — deleted `_posts/2024-06-20-How-To-Protect-Web-Services-with-OpenIG copy.md`, a `layout: redirect` post pointing at `/blog/2025-11-05-openig-getting-started`. It was not in the issue, but it was visible: an empty card "How To Protect Web Services With Openig copy" on `/blog/page10/`, and a `noindex` URL listed in `sitemap.xml`. Nothing links to its `…-OpenIG-copy` URL; the original `2024-06-20-How-To-Protect-Web-Services-with-OpenIG` article is kept. - **File name with a space** — renamed `_posts/2026-02-04-opendj-5-0-3-released .md` to `2026-02-04-opendj-5-0-3-released.md`. The URL stays `/blog/2026-02-04-opendj-5-0-3-released`. - **Share links** — `_includes/share-buttons.html` now uses `https://twitter.com/intent/tweet?url=…` instead of the deprecated `http://twitter.com/home?status=…`, and `https://www.facebook.com/sharer/sharer.php?u=…` instead of `http://…/share.php`; the shared URL is URL-encoded on all four buttons, LinkedIn included. Every share window opens with `window.open(url, '_blank', 'noopener')`, so the social site gets no `window.opener` back to this tab. - **Pinterest button** — it was wrapped in `{% if page.image %}`, which no page sets, so it never rendered (and it passed an empty `url=`). It now renders when the page has a non-empty `imageurl` and passes the page URL, `/assets/img/<imageurl>` and the title (`landing-title` or `title`), all URL-encoded, to `https://www.pinterest.com/pin/create/button/`. The six OpenIDM posts point at `openidm-og.png`, which #244 adds; until it is merged their Pinterest image, like their `og:image`, is a 404. The fourth item of the issue (empty `imageurl: ''`) is fixed in #239. Fixes #238 ## Verification Built the site with `bundle exec jekyll build` (Ruby 3.1, as in CI) and ran the same `htmlproofer` internal-link check as the workflow: no errors. - Compared with a build of `master`, the only removed output file is `blog/2024-06-20-How-To-Protect-Web-Services-with-OpenIG-copy.html`; `blog/2026-02-04-opendj-5-0-3-released.html` keeps its path. - `sitemap.xml` and the blog pages no longer mention the `-copy` URL. - Share buttons render e.g. `https://twitter.com/intent/tweet?url=https%3A%2F%2Fwww.openidentityplatform.org%2Fblog%2F2025-12-18-openam-vs-keycloak` and `https://www.linkedin.com/shareArticle?mini=true&url=https%3A%2F%2Fwww.openidentityplatform.org%2Fblog%2F2025-12-18-openam-vs-keycloak&title=&summary=&source=`. - All 513 rendered `window.open(…)` calls (135 pages × 3 buttons + 108 Pinterest buttons) pass `'_blank', 'noopener'`. - The Pinterest button renders on 108 of the 135 pages with share buttons; the other 27 have no `imageurl`, so there is no image to pin. Example: `https://www.pinterest.com/pin/create/button/?url=https%3A%2F%2Fwww.openidentityplatform.org%2Fblog%2F2025-12-18-openam-vs-keycloak&media=https%3A%2F%2Fwww.openidentityplatform.org%2Fassets%2Fimg%2Fopenam-og.png&description=OpenAM+vs+Keycloak`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six OpenIDM posts reference
imageurl: 'openidm-og.png', butassets/img/openidm-og.pngdid not exist, so theirog:image,twitter:imageandBlogPostingJSON-LDimagepointed to a 404:_posts/2024-09-10-openidm-ad-idm.md_posts/2024-11-13-openidm-can-your-idm-play-chess.md_posts/2025-05-13-openidm-two-way-ad-opendj.md_posts/2025-07-16-openidm-6-3-0-released.md_posts/2025-11-05-openidm-getting-started.md_posts/2026-02-05-openidm-7-0-2-released.mdThis PR adds the image, generated from
openidm-logo.pngin the same format asopenam-og.png,opendj-og.pngandopenig-og.png: 1024×512 RGBA, opaque white background, the logo scaled to 921 px wide and centered (content box x 52–972, centre 512, 255.5 — the same as the other three). No post or template changes are needed for these six posts.It also adds
assets/img/openicf-og.png, the nice-to-have from the issue, generated the same way fromopenicf-logo.png, and points all 13 OpenICF posts at it: 10 used the bareopenicf-logo.png, and 3 (1.8.0,2.0.1,2.0.3) had noimageurland fell back to the GitHub avatar.The empty
imageurl: ''from the issue is fixed in #239.Fixes #232
Verification
Built the site with
bundle exec jekyll build(Ruby 3.1, as in CI) and ran the workflow'shtmlprooferinternal-link check: no errors. OpenIDM posts renderog:image/ JSON-LDimageas…/assets/img/openidm-og.png, OpenICF posts as…/assets/img/openicf-og.png; no rendered page referencesopenicf-logo.pngas its image any more. This branch merges cleanly with #239–#243 (checked withgit merge-tree), including #243, which removescanonical:two lines below in the same OpenICF posts.Preview