Conversation
- partials/sec-release-levels.adoc: drop the appendix heading, id and intro that duplicated the including appendix page; with the leveloffset added for Antora the heading became a level-0 section and its id was assigned twice. - reference/handlers-conf.adoc: close the nested [open] ==== block of the Router "openApiValidation" properties before the enclosing "--" block. Fixes OpenIdentityPlatform#182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
Changes
partials/sec-release-levels.adoc: removed the[appendix],[#appendix-interface-stability],== Release Levels and Interface Stabilityheading and the intro paragraph. They repeated the heading ofreference/appendix-interface-stability.adoc, which includes this partial. On the site the converter adds:leveloffset: -1to the page, so the repeated==became a level-0 section (level 0 sections can only be used when doctype is book), and its id was assigned twice (id assigned to section already in use: appendix-interface-stability). The rendered page also had an empty<h2 id="appendix-interface-stability">; the PDF book had the appendix heading nested in itself. The heading and intro stay on the including page.reference/handlers-conf.adoc: the nested[open]+====block of the RouteropenApiValidationproperties (added in OpenAPI/Swagger routes loader and request/response validator #150/Add OpenApiMockResponseHandler — spec-driven mock API with realistic test data #155) was never closed — the enclosing--came right after it (unterminated open block). Added the closing====aftermockMode.The
releaseversion: 5.2.4in the component descriptor, also mentioned in the issue, lives in doc.openidentityplatform.org and is not changed here.Verification
reference/index.adocandgateway-guide/index.adoc: before —unterminated example blockathandlers-conf.adoc:780/781; after — no messages.openApiValidationoptions render as two open blocks withmockModeinside.skipping reference to missing attributewarnings (${true},${userid}, …) in expressions/filters/handlers/chap-auditing — the text renders as written.