Repository navigation
⚕️♻️:correct who the authors file names - #917
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe contributor listing now names Jorge Bucaran instead of Princess Irulen. The project terms list no longer contains ChangesRepository metadata maintenance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The contributor and terminology updates are consistent with the requested historical corrections, with no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
`AUTHORS` got both ends of its list wrong. It named an identity that has written nothing here, and left out someone who wrote a commit. Out: `Princess Irulen <grimes@open.inf.is>`. No commit in this repository's history is authored by it, under that name or that address. Nor is it a contributor whose work went unrecorded. The roster this repository's own ADR links to lists it among the organization's AI non-persons, beside the assistant and the grammar checker. Six commits from early 2024 carry it as `Co-authored-by:`, which is how it came to be read as a person. The portal settled the same entry in August, and dropped it and the two mailmap lines that canonicalized an identity with nothing left to canonicalize. This is the copy that was missed. In: `Jorge Bucaran <mail@jorgebucaran.com>`, who authored `eaad083` in March 2024 and signed it off himself. One commit is a contribution, and the file records contributors rather than regulars. The order holds: 2022 for the first, 2023 for the second, 2024 for the third, which is what the header says the file is sorted by. The spelling term for the name that left goes with it, since the word now appears nowhere else. Those six commit messages are not touched. They sit on the default branch of a public repository and have for two years, and rewriting them would change every commit since, for one wrong trailer each. What stops the next one is the check, not the history. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
8825d34 to
154ee1d
Compare
Summary
AUTHORSgot both ends of its list wrong. It named an identity that has written nothing here, and left out someone who wrote a commit.Princess Irulen <grimes@open.inf.is>Jorge Bucaran <mail@jorgebucaran.com>eaad083in March 2024 and signed it off himselfThe entry that leaves
No commit in this repository's history is authored by it, under that name or that address. Nor is it a contributor whose work went unrecorded: the roster that this repository's own ADR 0004 links to lists it among the organization's AI non-persons, beside the assistant and the grammar checker.
Six commits from early 2024 carry it as
Co-authored-by:, which is how it came to be read as a person in the first place. The portal settled the same entry in August, and dropped the two mailmap lines that canonicalized an identity with nothing left to canonicalize. This is the copy that was missed.The spelling term for the name goes with it, since the word now appears nowhere else in the tree.
The entry that arrives
One commit is a contribution. The file records contributors, not regulars, and it has recorded people with less than that.
The order still holds, which matters because the header says the file is sorted by first contribution: 2022 for Derek Lewis, 2023 for Andrew Powell, 2024 for Jorge Bucaran.
What this does not do
The six commit messages are untouched. They sit on the default branch of a public repository and have for two years, and rewriting them would change every commit since, for one wrong trailer each. What stops the next one is the check in #916, not the history.
Andrew Powell stays where he is. He has no authored commits here either, only the attribution in
5f4cb4c, where the pull request template was derived fromrollup/pluginswith his permission. Unlike the entry that leaves, he is a person, and whether that counts as a contribution to this repository is a call for a maintainer rather than for this pull request.Validation
git logconfirms the first-contribution dates the order depends onIrulenappears nowhere else in the tree before removing the termSummary by CodeRabbit