Repository navigation
fix(formplayer): support object GPS questions - #1033
najuna-brian merged 10 commits into
Conversation
|
Hi @najuna-brian , @Mishael-2584 , @r0ssing , I’ve completed the changes and opened the PR. When you get a chance, could you please review it and let me know if there’s anything I should adjust? Thank you. |
Mishael-2584
left a comment
There was a problem hiding this comment.
The renderer now supports object GPS schemas and stores captured data in the corresponding shape, while preserving the legacy string path.
No blocking findings from code review. Formplayer CI and the Android build are green. My local test run was blocked by missing jsdom in the existing dependency installation.
Approved from my side. Good Stuff! @Grace256c
Optional coverage improvement: add cases for legacy string values and an object GPS schema without properties, matching the original reproduction.
|
Thank you @Mishael-2584 for the suggestion. I added coverage for legacy string GPS values and object GPS schemas without properties, and pushed the update. |

What & Why
Fix GPS questions using the documented
type: "object"schema so they render and store location data correctly.The GPS renderer previously used
formatIs('gps'), which only matched string schemas. It also expected existing GPS values to be JSON strings and always serialized newly captured locations as strings.This change supports object-based GPS schemas while preserving compatibility with legacy string-based GPS values.
Closes #1024.
Type of Change
Component(s) Changed
Testing
Added coverage for:
Local verification:
pnpm run lintpnpm run format:checkpnpm test run— 39 test files, 252 tests passedpnpm run buildChecklist
Closes #1024