Repository navigation
Conversation
Next draws its own approval panel and honest tool rows: target, state, the user's decision kept apart from the execution result, and interrupted calls shown as cancel requested, then cancelled. Approval safety, shared with Classic: a request opens focused on deny, and keys other than Escape count only after a 400 ms quiet gap, which each ignored key restarts. The panel never drops options or silently shortens the command; hidden input rows are counted. Decisions are recorded against the model's tool-use id, carried to the permission request through a task-local set around each tool call. Untrusted text is shown with control, C1 and bidi characters made visible. Refs #411
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 1, 2026
Deny focus and the quiet-gap arming are now applied by PermissionRequest::guarded, which the loop uses for the Next renderer only. Classic opens requests on the first option and accepts keys at once, as before; its permission goldens match the #410 base again. Classic also clears its tool rows on cancel as before. Refs #411
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #411. Stacked on #429 (#410). Retarget to
mainafter the stack merges. Classic stays the default renderer.What this ships
The engine-local slice of T4 in Next (
COVEN_CODE_UI=next): readable tool rows, an approval panel that says who enforces it, and approval keys that a stray keystroke cannot trigger.allowed, runningis not success, and a denied call saysdenied.cancel requested, thencancelled, instead of vanishing. The engine's closing error result updates that row; it does not add a second failed row.engine-local), the project, who enforces it (this process; no daemon protection applies), and what each key does, including thatpsaves a persistent allow rule. Space is given out by priority: every option first, then the danger note and title, then as much of the input as fits. If input does not fit, the panel says how many rows are hidden.terminal_safe, which shows C0 and DEL in caret notation and replaces C1 and bidi controls. Ratatui already drops control characters, so this is defense in depth that makes them visible.Classic is unchanged
The approval guards are applied only in Next, through
PermissionRequest::guarded:Classic opens requests on the first option and accepts keys at once, as before. Its permission goldens match the #410 base byte for byte. Classic still clears its tool rows on cancel. Offering the same guards to Classic would be a separate decision.
Review
An independent reviewer read the first version. Resolved:
perm-…request id, so no real row ever showed allowed or deniedcall_id); keyboard and remote-control decisions record against itcancelledanderrorrunning; interrupted rows and decisions were never clearedNew tests fail without their fixes: the quiet-gap test, the duplicate-row test and the whole-command test were each run red against the code they cover.
Not changed, recorded here instead:
porPstill decides at once once armed; they are not focus-only.ToolEndfor an interrupted call is dropped; the durable result covers it.Verification
All results are on the head of this PR.
cargo test -p claurst-tui --locked --test next_toolscargo test --workspace --locked --no-fail-fastcargo clippy --workspace --all-targets --locked -- -D warningsThere is no tmux approval journey. The fake
clauderuns tools inside its own process, so it never reaches the engine-local permission path; a real-binary approval check needs a fake provider that emits a tool use.Still open for #411