Skip to content

OpenConceptLab/ocl_online#655 | Show the versioning mode in version details - #97

Draft
snyaggarwal wants to merge 1 commit into
mainfrom
ocl_online#655
Draft

snyaggarwal wants to merge 1 commit into
mainfrom
ocl_online#655

Conversation

@snyaggarwal

Copy link
Copy Markdown
Contributor

OpenConceptLab/ocl_online#655

What this does

This shows a version's Versioning Mode in the version details on the Versions tab: Carry Forward or Isolated. The value comes from the new versioning_mode field in oclapi2. Unknown values fall back to title case.

  • src/components/repos/versionsTab.styles.js: adds versioning_mode to the version attribute labels and order, and translates its value.
  • Translations: en, es, pt-BR and zh.

Testing

  • npm test: 122 tests pass.
  • eslint is clean on the changed file.

The backend part is in OpenConceptLab/oclapi2 on the branch of the same name.

🤖 Generated with Claude Code

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings in this frontend change.

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second review: the head SHA is unchanged and I found no actionable findings.

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third-round review

The head is unchanged from the previous review (6442269a). I rechecked the PR in the context of the updated backend contract and found no new actionable findings, performance issues, or nits.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant