Repository navigation
fix(widgets): real thumbnails for cloud-only files; bars agree with their number - #88
Merged
Merged
Conversation
…heir number Quick Look has no preview for a OneDrive or iCloud file that is not downloaded, so the newest screenshots showed a generic icon — and the icon was kept for good. Read such an image (≤ 25 MB) to make its thumbnail, and retry a stand-in icon every ten minutes. A bar that fills the other way from its "97% left" is turned around, list initials take the widget's colour, and screenshot names shorten to their time, as in the approved design. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #87, from the user's check that the screenshot widget showed no previews and looked unlike the approved design.
-icon.pngand the picture is retried every 10 minutes. Before this, the stand-in icon was saved under the picture's name and kept for good. The name scheme is bumped (v2) so the old ones are pruned.SharedShelf.matchingBar, tested).Checked:
swift test567 tests, 0 failures. Both extension schemes build. Previews rendered from real shared data. Signed build installed on june-mba: 5 real thumbnails plus 7 icons for OneDrive files that can't be downloaded right now (the OneDrive app isn't running, so reads time out).🤖 Generated with Claude Code