Skip to content

Find optimal mesh resolution regarding wavelength - #41

Open
thomaslepoix wants to merge 14 commits into
mainfrom
dev/optimal-resolution
Open

thomaslepoix wants to merge 14 commits into
mainfrom
dev/optimal-resolution

add 'Expressed as wavelength divisor' indication for d & dmax & diago…

e929e30
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 17, 2026 in 5m 35s

Quality Gate failed

Annotations

Check warning on line 176 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int'

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYli5&open=AaEiZFRMhvuiaV7XYli5&pullRequest=41

Check warning on line 650 in src/domain/board.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const".

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFiuhvuiaV7XYljV&open=AaEiZFiuhvuiaV7XYljV&pullRequest=41

Check failure on line 230 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYli-&open=AaEiZFRMhvuiaV7XYli-&pullRequest=41

Check warning on line 230 in src/infra/parsers/parser_from_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFpOhvuiaV7XYljY&open=AaEiZFpOhvuiaV7XYljY&pullRequest=41

Check warning on line 44 in src/ui/qt/edit/edit_model_conflict_diagonal_or_circular_zone.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "does_succeed" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFOlhvuiaV7XYli1&open=AaEiZFOlhvuiaV7XYli1&pullRequest=41

Check warning on line 38 in src/ui/qt/edit/edit_model_angle.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "does_succeed" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFXAhvuiaV7XYljP&open=AaEiZFXAhvuiaV7XYljP&pullRequest=41

Check failure on line 161 in src/infra/serializers/serializer_to_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFqfhvuiaV7XYljm&open=AaEiZFqfhvuiaV7XYljm&pullRequest=41

Check failure on line 360 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYljF&open=AaEiZFRMhvuiaV7XYljF&pullRequest=41

Check warning on line 202 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYljJ&open=AaEiZFRMhvuiaV7XYljJ&pullRequest=41

Check warning on line 47 in src/infra/serializers/serializer_to_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "domain::Material::Type".

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFqfhvuiaV7XYlji&open=AaEiZFqfhvuiaV7XYlji&pullRequest=41

Check failure on line 27 in src/ui/qt/edit/edit_model.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "explicit" keyword to this constructor.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFPxhvuiaV7XYli2&open=AaEiZFPxhvuiaV7XYli2&pullRequest=41

Check failure on line 38 in src/domain/global.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFhZhvuiaV7XYljU&open=AaEiZFhZhvuiaV7XYljU&pullRequest=41

Check warning on line 322 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "d" is "class ui::qt::EditDialogPerAxisPerCriteria *".

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYljD&open=AaEiZFRMhvuiaV7XYljD&pullRequest=41

Check warning on line 32 in src/domain/mesh/meshline_policy.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFhGhvuiaV7XYljT&open=AaEiZFhGhvuiaV7XYljT&pullRequest=41

Check warning on line 470 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYljI&open=AaEiZFRMhvuiaV7XYljI&pullRequest=41

Check warning on line 40 in src/utils/enum_utils.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFn5hvuiaV7XYljX&open=AaEiZFn5hvuiaV7XYljX&pullRequest=41

Check warning on line 146 in src/infra/parsers/parser_from_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 38 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFpOhvuiaV7XYljc&open=AaEiZFpOhvuiaV7XYljc&pullRequest=41

Check warning on line 66 in src/ui/qt/edit/edit_model_per_axis_per_criteria.ipp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFTzhvuiaV7XYljM&open=AaEiZFTzhvuiaV7XYljM&pullRequest=41

Check warning on line 36 in src/ui/qt/edit/edit_model_conflict_too_close_meshline_policies.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "does_succeed" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFKOhvuiaV7XYliz&open=AaEiZFKOhvuiaV7XYliz&pullRequest=41

Check warning on line 230 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 21 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYljA&open=AaEiZFRMhvuiaV7XYljA&pullRequest=41

Check failure on line 321 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYljC&open=AaEiZFRMhvuiaV7XYljC&pullRequest=41

Check warning on line 154 in src/infra/serializers/serializer_to_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::move" is never called on this rvalue reference argument.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFqfhvuiaV7XYljl&open=AaEiZFqfhvuiaV7XYljl&pullRequest=41

Check failure on line 128 in src/infra/parsers/parser_from_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 30 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFpOhvuiaV7XYljZ&open=AaEiZFpOhvuiaV7XYljZ&pullRequest=41

Check warning on line 170 in src/ui/qt/edit/edit_delegate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'std::size_t' (aka 'unsigned long') to 'int'

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFRMhvuiaV7XYli4&open=AaEiZFRMhvuiaV7XYli4&pullRequest=41

Check warning on line 168 in src/infra/serializers/serializer_to_csx.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'const std::size_t' (aka 'const unsigned long') to 'int'

See more on https://sonarcloud.io/project/issues?id=Open-RFlab_openemsh&issues=AaEiZFqfhvuiaV7XYljg&open=AaEiZFqfhvuiaV7XYljg&pullRequest=41