Repository navigation
docs(svdconv): explain field expansion and generator core - #2670
Merged
Merged
Conversation
thorstendb-ARM
marked this pull request as ready for review
October 22, 2026 12:44
Test Results 4 files - 41 40 suites - 125 39s ⏱️ - 13m 29s Results for commit 4cbc719. ± Comparison against base commit b6a936c. This pull request removes 1454 tests. |
edriouk
approved these changes
Oct 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2670 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 207 207
Lines 33545 33545
=======================================
Hits 29336 29336
Misses 4209 4209
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add three brief comments each to
SvdField::CalculateDim()andSfdGenerator::Generate(), explaining field expansion and the SFD generator core.Related code-scanning alerts: 13928
and 13854.
Validation
Six comment lines added; executable text is identical.
git diff --checkpassed.CodeQL confirmation is pending.
Checklist