Skip to content

docs(svdconv): explain field expansion and generator core - #2670

Merged
thorstendb-ARM merged 2 commits into
mainfrom
docs/svdconv-generator-comments
Oct 22, 2026
Merged

thorstendb-ARM merged 2 commits into
mainfrom
docs/svdconv-generator-comments

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Changes

Add three brief comments each to SvdField::CalculateDim() and
SfdGenerator::Generate(), explaining field expansion and the SFD generator core.

Related code-scanning alerts: 13928
and 13854.

Validation

Six comment lines added; executable text is identical. git diff --check passed.
CodeQL confirmation is pending.

Checklist

  • Unit tests: not applicable to comment-only changes.
  • Comments checked against the implementation and existing generator patterns.
  • Security impact reviewed: executable code unchanged.
  • Documentation updated in place.
  • Dependencies and TPIP: unchanged.

@thorstendb-ARM
thorstendb-ARM marked this pull request as ready for review October 22, 2026 12:44
@github-actions

Copy link
Copy Markdown

Test Results

  4 files   -    41   40 suites   - 125   39s ⏱️ - 13m 29s
281 tests  - 1 454  281 ✅  - 1 437  0 💤  - 17  0 ❌ ±0 
560 runs   - 3 593  560 ✅  - 3 524  0 💤  - 69  0 ❌ ±0 

Results for commit 4cbc719. ± Comparison against base commit b6a936c.

This pull request removes 1454 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

@thorstendb-ARM
thorstendb-ARM merged commit ffb32a7 into main Oct 22, 2026
6 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the docs/svdconv-generator-comments branch October 22, 2026 14:05
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.45%. Comparing base (ef98267) to head (01596b2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         207      207           
  Lines       33545    33545           
=======================================
  Hits        29336    29336           
  Misses       4209     4209           
Flag Coverage Δ
svdconv-cov 74.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/svdconv/SVDGenerator/include/SfdGenerator.h 100.00% <ø> (ø)
tools/svdconv/SVDModel/src/SvdField.cpp 79.19% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants