Skip to content

docs(xmlreader): preserve M415 diagnostic text in comment - #2669

Merged
thorstendb-ARM merged 3 commits into
mainfrom
docs/codeql-comment-clarity
Oct 22, 2026
Merged

thorstendb-ARM merged 3 commits into
mainfrom
docs/codeql-comment-clarity

Conversation

@thorstendb-ARM

@thorstendb-ARM thorstendb-ARM commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Replace the commented-out printf beside M415 with readable diagnostic text.

Related code-scanning alert: 196.

Validation

Exactly one comment changed; executable text is identical. git diff --check
passed. CodeQL confirmation is pending.

Checklist

  • Unit tests: not applicable to comment-only changes.
  • Comment checked against the diagnostic catalog.
  • Security impact reviewed: executable code unchanged.
  • Documentation updated in place.
  • Dependencies and TPIP: unchanged.

@thorstendb-ARM thorstendb-ARM changed the title docs: clarify XML reader and RTE model comments docs(xmlreader): preserve M415 diagnostic text in comment Oct 22, 2026
@thorstendb-ARM
thorstendb-ARM marked this pull request as ready for review October 22, 2026 12:34
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Test Results

  2 files   -    43   14 suites   - 151   15m 29s ⏱️ + 1m 21s
483 tests  - 1 252  483 ✅  - 1 235  0 💤  - 17  0 ❌ ±0 
966 runs   - 3 187  966 ✅  - 3 118  0 💤  - 69  0 ❌ ±0 

Results for commit 96c5fea. ± Comparison against base commit b6a936c.

This pull request removes 1252 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

♻️ This comment has been updated with latest results.

@thorstendb-ARM
thorstendb-ARM merged commit 5f04db7 into main Oct 22, 2026
21 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the docs/codeql-comment-clarity branch October 22, 2026 14:07
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.45%. Comparing base (ffb32a7) to head (cc33993).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2669   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         207      207           
  Lines       33545    33545           
=======================================
  Hits        29336    29336           
  Misses       4209     4209           
Flag Coverage Δ
buildmgr-cov 89.51% <ø> (ø)
packchk-cov 80.09% <ø> (ø)
packgen-cov 88.66% <ø> (ø)
projmgr-cov 95.01% <ø> (ø)
svdconv-cov 74.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants