Repository navigation
refactor(packchk): clean up CodeQL style findings - #2650
Merged
Merged
Conversation
Test Results 4 files 8 suites 7s ⏱️ Results for commit f69f6f4. ♻️ This comment has been updated with latest results. |
edriouk
approved these changes
Oct 21, 2026
thorstendb-ARM
marked this pull request as ready for review
October 21, 2026 12:40
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
- Coverage 87.45% 86.29% -1.16%
==========================================
Files 207 207
Lines 33545 33117 -428
==========================================
- Hits 29336 28578 -758
- Misses 4209 4539 +330
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
PackChk CodeQL findings for array parameter notation and sparse comments, without changing behavior.
CodeQL confirmation is pending.
Changes
const char**for CLI parameters, preserving the identical adjusted C++ types.CheckBoards().Limited to
tools/packchk. Validation: 8 unit tests, 41 integration tests and 67 before/after CLI comparisons passed.Only measured progress durations were normalized; the before/after executables are byte-identical.
Checklist