Skip to content

refactor(packchk): clean up CodeQL style findings - #2650

Merged
thorstendb-ARM merged 3 commits into
mainfrom
fix/packchk-codeql-cleanups
Oct 21, 2026
Merged

thorstendb-ARM merged 3 commits into
mainfrom
fix/packchk-codeql-cleanups

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Fixes

PackChk CodeQL findings for array parameter notation and sparse comments, without changing behavior.
CodeQL confirmation is pending.

Changes

  • Use const char** for CLI parameters, preserving the identical adjusted C++ types.
  • Document device-index, mounted-device and compatible-device checks in CheckBoards().

Limited to tools/packchk. Validation: 8 unit tests, 41 integration tests and 67 before/after CLI comparisons passed.
Only measured progress durations were normalized; the before/after executables are byte-identical.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Test Results

 4 files   8 suites   7s ⏱️
49 tests 49 ✅ 0 💤 0 ❌
98 runs  98 ✅ 0 💤 0 ❌

Results for commit f69f6f4.

♻️ This comment has been updated with latest results.

@thorstendb-ARM
thorstendb-ARM marked this pull request as ready for review October 21, 2026 12:40
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.29%. Comparing base (b7c824c) to head (f69f6f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
- Coverage   87.45%   86.29%   -1.16%     
==========================================
  Files         207      207              
  Lines       33545    33117     -428     
==========================================
- Hits        29336    28578     -758     
- Misses       4209     4539     +330     
Flag Coverage Δ
packchk-cov 80.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/include/PackChk.h 100.00% <ø> (ø)
tools/packchk/src/PackChk.cpp 84.61% <100.00%> (ø)
tools/packchk/src/ParseOptions.cpp 69.29% <100.00%> (ø)
tools/packchk/src/ValidateSyntax.cpp 78.72% <ø> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thorstendb-ARM
thorstendb-ARM merged commit b6a936c into main Oct 21, 2026
21 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the fix/packchk-codeql-cleanups branch October 21, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants