fix: [SDK-5198] keep the system navigation bar visible for HTML in-app messages - #2767
Open
abdulraqeeb33 wants to merge 1 commit into
Open
abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
… HTML in-app messages Hiding the bar collapsed the activity insets and shifted the host app's own bottom bar. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📊 Diff Coverage ReportDiff Coverage Report (Changed Lines Only)Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff). Changed Files Coverage
Overall (aggregate gate)2/2 touched executable lines covered (100.0% — requires ≥ 80%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Full-bleed HTML in-app messages no longer hide the Android system navigation bar.
Details
Motivation
On Android, an HTML in-app message hid the system navigation bar for as long as it was showing. The activity's navigation inset collapsed, so an app bottom bar laid out from that inset shifted down. Dismissing the message restored both. Block Editor messages were unaffected because they are not full bleed.
Full-bleed WebViews requested
SYSTEM_UI_FLAG_HIDE_NAVIGATIONandSYSTEM_UI_FLAG_IMMERSIVE. They now request layout flags only, so the message still draws behind the bar and the bar stays visible.Scope
Applies to full-bleed in-app messages (
remove_height_margin), which is how HTML Editor messages are sent. Messages with margins are unchanged. The bottom edge of a full-bleed message can sit under the visible system bar. HTML that honorssetSafeAreaInsetscan pad for that.Testing
Unit testing
WebViewManagerDismissCleanupTestsasserts a full-bleed WebView does not setSYSTEM_UI_FLAG_HIDE_NAVIGATIONorSYSTEM_UI_FLAG_IMMERSIVE, and still sets the layout-behind flags. Dismiss cleanup is unchanged.Manual testing
HTML Editor message, edge-to-edge red page, 3-button navigation, demo app on an emulator.
Before: the three buttons disappear while the message is up.
After: the three buttons stay on the white bar.
Affected code checklist
Checklist
Overview
Testing
Final pass