Repository navigation
fix(tui): highlight Containerfile, Dockerfile.*, and shell dotfiles - #433
amandeavor wants to merge 2 commits into
Conversation
languageForPath missed Podman Containerfiles, Dockerfile.dev-style variants, GNUmakefile, Vagrantfile, and common shell rc files. Add exact-name mappings, a Dockerfile.*/Containerfile.* prefix rule, and dedicated highlight tests. Closes Observal#427
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Filename mappings and path resolution packages/tui/src/highlight.ts, packages/tui/test/highlight.test.ts |
Added mappings for additional filenames and prefix handling for Dockerfile variants. Tests cover the new mappings, existing extensions, mixed-case names, Windows-style paths, and unknown names. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix · Severity of issue fixed: Low
Merge Risk: 
0e97a
-
The filename-highlighting change is mergeable after normal checks.
🚥 Pre-merge checks | ✅ 3 | ❌ 2
-
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution Description check ⚠️ WarningThe description summarizes the change, links issue #427, and reports a targeted test. It does not follow the required template because it omits the Purpose, Approach, How was this tested?, Learning, C…Update the description to use the required headings. Add the purpose, implementation approach and compatibility or security impact, complete testing details including all relevant checks and unverifiable checks, complete the checklist, and … Docstring Coverage ⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold. ✅ Passed checks (3 passed)
-
Check name Status Explanation Title check ✅ Passed The title clearly summarizes the main change: syntax highlighting for Containerfile, Dockerfile variants, and shell dotfiles. Linked Issues check ✅ Passed Issue [ #427] requires mappings for Containerfile, Dockerfile.* variants, shell dotfiles, GNUmakefile, and Vagrantfile.highlight.tsadds these mappings and handles bothDockerfile.*and `Container…Out of Scope Changes check ✅ Passed The reviewed changes are limited to languageForPathmappings and focused automated tests. These changes directly implement the objectives in issue [#427]. No unrelated change is shown.
Full details: Description check
-
Explanation
The description summarizes the change, links issue
#427, and reports a targeted test. It does not follow the required template because it omits the Purpose, Approach, How was this tested?, Learning, Checklist, and AI assistance sections.Resolution
Update the description to use the required headings. Add the purpose, implementation approach and compatibility or security impact, complete testing details including all relevant checks and unverifiable checks, complete the checklist, and provide the AI assistance information.
-
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
languageForPathnow recognizes:Containerfile/Containerfile.*(dockerfile)Dockerfile.*variants such asDockerfile.devGNUmakefile,Vagrantfile.bashrc,.zshrc,.bash_profile,.profileAdds
packages/tui/test/highlight.test.tscovering new names, existing extensions, mixed case, Windows paths, and unknown names.Closes #427
Test plan
pnpm --filter @axl/tui exec node --test test/highlight.test.ts(5 pass)Summary by CodeRabbit