Repository navigation
fix: keep explicit dataflow values when check() applies defaults - #374
Open
Svastikkka wants to merge 1 commit into
Open
Svastikkka wants to merge 1 commit into
Svastikkka wants to merge 1 commit into
Conversation
Svastikkka
force-pushed
the
fix/373-tm-check-overwrites-explicit-dataflow-pr
branch
from
October 29, 2026 05:21
3f186a6 to
7c7eb83
Compare
Svastikkka
marked this pull request as ready for review
October 29, 2026 05:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373
Since the move to Pydantic,
TM.check()overwrote a dataflow's explicitly setprotocol, ports and encryption flag with the sink's or source's defaults, so threats were evaluated against the wrong values.Defaults are now only filled in when the model didn't set the field (
model_fields_set), for both request and response flows, which brings back the 1.3.1 behaviour.Testing:
check().'HTTPS' 443 Trueand the same findings as 1.3.1.