Repository navigation
Conversation
Collaborator
|
I like the idea of a file explaining the properties and threats mechanism, as it will make it easier for LLMs to work with pytm, but I question having Controls explained there rather than added to the current --describe mechanism. |
izar
requested changes
Oct 31, 2026
izar
left a comment
Collaborator
There was a problem hiding this comment.
Please add Controls description to the existing mechanism.
Author
|
Added |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model properties used in threat conditions are hard to discover, and
--describe Controlspreviously failed. AddControlsto the existing description registry so the command lists control fields, their descriptions, and defaults using the same mechanism as element classes.Move the six control definitions covered by the guide into their Pydantic field descriptions:
checksInputBounds,validatesInput,sanitizesInput,usesStrongSessionIdentifiers,authenticatesSource, andauthorizesSource. Keep the guide focused on how properties drive findings, a runnable example, and howsourceFilesis used by--stale. Link to--describe Controlsfrom the README and guide.Validation:
pytest -q— 254 passed.Controls, combinedServer Controls, and unknown class errors.python tm.py --describe Controlson Windows (Python 3.11).git diff --checkpassed.Closes #28.