Repository navigation
Switch to ruff - #365
Switch to ruff#365Alicipy wants to merge 7 commits into
Conversation
|
LGTM |
Also drop the UP007 ignore, we require Python 3.11 now. Signed-off-by: Stefan Kraus <dev@stefankraus.org>
Signed-off-by: Stefan Kraus <dev@stefankraus.org>
Signed-off-by: Stefan Kraus <dev@stefankraus.org>
Nothing enforced formatting until now, so a few files had drifted. Signed-off-by: Stefan Kraus <dev@stefankraus.org>
ruff finds the files on its own, so the wildcard lists can go. Signed-off-by: Stefan Kraus <dev@stefankraus.org>
Signed-off-by: Stefan Kraus <dev@stefankraus.org>
Signed-off-by: Stefan Kraus <dev@stefankraus.org>
c20a5e4 to
766419b
Compare
|
@izar is that change to 'ruff' still wanted / needed? Just asking as when we merge in more things, we need to resolve conflicts and changes again. |
|
hi @Alicipy - to be honest, I am still looking for a good reason to move to ruff. In my view, black is a perfectly fine solution, while ruff brings with it the whole Go environment - at least in my Ubuntu box. |
|
Hey izar, yes, I would love to convince you, as I personally see a lot of advantages from ruff over black, also in the current project context:
Not so relevant for the project as it's not really big, but:
I don't get the point with Go unfortunately, as ruff is written in Rust and with 'pip install ruff', you get a prebuilt binary without any toolchain. Do you install it with snap, apt, or others? If you'd still prefer black, that's fine, I was just asking for a decision so I know if we/I need to take care of this PR in any form |
As already mentioned in #331, this PR will switch 'black' fully to ruff.
There was a configuration for ruff already, but black was the main formater used before. This change removes black, reformats all files, fixes some linting errors, and enforces the rules in CI as well, so no drift happens now.