Repository navigation
Align PROMCODE build, tests, containers and CI - #16
Open
berezovskyi wants to merge 3 commits into
Open
berezovskyi wants to merge 3 commits into
berezovskyi wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy PROMCODE consistently at the root application context
/in the container, Maven Jetty and Cargo/Tomcat. Align the Designer model, Swagger server URL, README routes and RDF snapshots; OSLC endpoints remain under/oslc/. Fix Fuseki persistence and the Tomcat startup command.Align this Lyo 7 server on Java 25 across Maven, CI and Jetty images: the required Jetty JDK 27 image is unavailable. Preserve the existing Lyo SNAPSHOT dependencies and contributor guidance. Add JUnit 6 tests for PROMCODE RDF round trips and snapshots, encoded resource URIs, and StorePool SPARQL requests through MockServer. Use SLF4J/Logback, activate Enforcer and Spotless, and provide optional scoped OpenRewrite and SpotBugs profiles.
Harden the Actions workflows with pinned actions and minimal permissions, a stable
buildcheck on PRs and merge groups, canonical Lyo HEAD defaults, and trusted multi-architecture GHCR publication. Publication logs and job summaries list every pushed tag and the image digest; image-scoped GitHub Actions caching is retained, with scheduled fresh rebuilds. Keep startup/configuration in README, developer checks in DEVELOPMENT, contribution rules in CONTRIBUTING, and brief agent notes in AGENTS; add EditorConfig.Validation:
mvn clean verify -Dselfie=readonly: three JUnit 6 tests passed; formatting and Enforcer checks passed./oslc/server URL passed. Artifact survived Fuseki container recreation./oslc/.--offline --pedantic, Compose parsing and packaged logging-binding inspection passed.The optional SpotBugs profile reports the existing generated
Applicationsuperclass-name collision; it remains unsuppressed and documented. Podman is unavailable locally, so its engine/parser was not exercised. Repository/inherited rulesets and workflows contain no automatic Copilot review requests; author-level automatic-review preferences could not be inspected.Repository settings are applied: main requires PRs and the passing build check, with a squash merge queue, linear history, and force-push/deletion protection. Merge commits are disabled; squash/rebase, branch updates, and branch deletion after merge are enabled.