Repository navigation
Show flow diagnostics plots in plot window after project load - #15075
Merged
Merged
Conversation
Flow plots derive from RimViewWindow, not RimPlotWindow, and were missing from RiuPlotMainWindow::viewWindows(). Applying the default dock layout on project open therefore did not re-add their dock widgets. 3D views docked in the plot window are now listed by the plot main window only, and are still activated as the active 3D view so the 3D main window toolbars (e.g. time step animation) are refreshed.
jonjenssen
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow diagnostics plots were missing from the plot main window after project load. They become visible after toggling them in the project tree.
Cause
Flow diagnostics plots derive from
RimViewWindow, notRimPlotWindow, and were therefore missing fromRiuPlotMainWindow::viewWindows(). Applying the default dock layout on project open did not re-add their dock widgets.Changes
RiuPlotMainWindow::viewWindows()lists all view windows docked in the plot window, including flow diagnostics plots and 3D views docked in the plot window.RiuMainWindow::viewWindows()excludes 3D views docked in the plot window, so each dock widget is managed by exactly one main window.RiuMainWindow::setActiveViewer()forwards 3D views docked in the plot window to the plot main window. This makes selection in the 3D project tree activate the view.RimDockWindowController::setAsActiveViewer()always activates 3D views as the active 3D view, also when docked in the plot window, so the 3D main window toolbars (e.g. time step animation) are refreshed.RiuPlotMainWindowTools::remove3dViewsFromDocking()uses the plot window list of views.Extracted from #15072.