[kriben]

No description provided.

[magnesj]

Automated code review (OCR)

28 files reviewed, 2 medium findings in RimWorkflowDefinitionTools.cpp.

Medium

• RimWorkflowDefinitionTools.cpp:83-84 [bug]: If ref is an array with fewer than two items (e.g. ref: [task]), the field ends up empty. An empty field counts as a switch-branch guard (isSwitchBranch()), so a malformed field condition is silently read as a switch-branch condition, and the validation message is misleading.
  Recommendation: require exactly two items and report malformed input.

• RimWorkflowDefinitionTools.cpp:1519 [bug]: Fields that have only enum or const and no type (e.g. a pydantic string Literal) are not treated as string fields. Text like true or 1 is then parsed as a bool or number and does not match the string labels.
  Recommendation: treat the field as a string when every enum/const value is a string.

[kriben]

Both findings were valid and are fixed:

• A ref array without exactly two items is no longer read as a switch-branch guard. It is flagged as malformed and validation reports "A field condition must refer to a task and an output field".
• A field with only enum/const and all string values is now treated as a string field, so true and 1 stay strings.

Unit tests cover both cases.