Skip to content

#14895: Improve stability when importing malformed input files - #14896

Merged
magnesj merged 5 commits into
OPM:devfrom
magnesj:14895-stability-malformed-input
Oct 12, 2026
Merged

magnesj merged 5 commits into
OPM:devfrom
magnesj:14895-stability-malformed-input

Conversation

@magnesj

@magnesj magnesj commented Oct 10, 2026

Copy link
Copy Markdown
Member

Improves stability when importing malformed or corrupted input files. Such files are now rejected or skipped instead of crashing or reading/writing outside allocated memory.

  • GRDECL import: reject grids when keyword sizes do not match SPECGRID (null grid was dereferenced), and SPECGRID with fewer than three values.
  • Perforation interval import: skip records with too few fields.
  • VTK/VTU import: reject connectivity indices outside the vertex array (surface importer and RifVtkReader).
  • Dual porosity: skip the unpaired last PORV value for odd value counts.
  • ROFF: update roffcpp submodule to validate array lengths and token counts (Validate array lengths and token counts when parsing ROFF files (GHSA… CeetronSolutions/roffcpp#29).

Each fix has a regression test.

Fixes #14895.

@magnesj magnesj self-assigned this Oct 10, 2026
@magnesj
magnesj requested a review from kriben October 10, 2026 06:30
@magnesj
magnesj marked this pull request as ready for review October 10, 2026 06:30
@magnesj
magnesj merged commit ab96c52 into OPM:dev Oct 12, 2026
11 checks passed
@magnesj
magnesj deleted the 14895-stability-malformed-input branch October 12, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve stability when importing malformed input files

2 participants