Repository navigation
HDXDSYS-3018 Improve resource download handling - #125
Merged
Merged
Conversation
…ctories from download filename Resource.download/download_datastore sent the Authorization header to any resource URL, including external hosts. The filename built from the resource name and format could contain absolute paths or ../ and write outside the target folder.
Test Results194 tests +1 193 ✅ ±0 1m 6s ⏱️ -4s For more details on these failures, see this check. Results for commit 41bc5ad. ± Comparison against base commit a70b2a5. |
mcarans
changed the title
|
coverage: 97.318% (+0.01%) from 97.308% — fix/download-auth-and-filename into main |
mcarans
changed the title
mcarans
added a commit
that referenced
this pull request
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
test_download_security