Skip to content

[16.0][FIX] spreadsheet_oca: compute filename per record - #149

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
prashantpag26:16.0-fix-spreadsheet_oca-compute-filename
Nov 19, 2026
Merged

OCA-git-bot merged 1 commit into
OCA:16.0from
prashantpag26:16.0-fix-spreadsheet_oca-compute-filename

Conversation

@prashantpag26

Copy link
Copy Markdown

Backport of #136 (18.0) and #146 (17.0).

_compute_filename reads self.name inside for record in self, so computing filename on more than one record at once (list views, exports, batch read()) raises:

ValueError: Expected singleton: spreadsheet.spreadsheet(2, 3)

This uses record.name.

This was not run in a live Odoo instance.

_compute_filename read self.name inside the loop over self, so
computing the filename of several spreadsheets at once raised an
Expected singleton error.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-149-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit a8f81d5 into OCA:16.0 Nov 19, 2026
6 of 8 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1c72107. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@pedrobaeza The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_spreadsheet_oca-16.0.1.9.3-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_spreadsheet_oca-16.0.1.9.3-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Bad Request                                                            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants