Repository navigation
Conversation
The control panel template still used the Odoo 17 Dropdown API (togglerClass prop and toggler slot). In debug mode, where Owl validates props, opening a spreadsheet with collapsed breadcrumbs raised "Invalid props for component 'Dropdown'" and the spreadsheet could not be opened. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control panel template still uses the Odoo 17
DropdownAPI (togglerClassprop andtogglerslot).In debug mode, where Owl validates props, opening a spreadsheet when the breadcrumbs are collapsed (three levels or more) fails with:
and the action manager goes back to the previous view. Without debug mode the props are not validated, so the error goes unnoticed.
#112 fixed the missing components of
SpreadsheetControlPanel; this one updates the twoDropdownusages of the template to the Odoo 18 API, as done inweb.Breadcrumbsandweb.ControlPanel.To reproduce: with
?debug=1, open a spreadsheet from an action that already has two breadcrumbs.