Skip to content

[IMP] barcode_scanner: Use specific assets & move elements in a more OWL Way - #31

Open
etobella wants to merge 12 commits into
OCA:18.0from
dixmit:18.0-assets
Open

etobella wants to merge 12 commits into
OCA:18.0from
dixmit:18.0-assets

Conversation

@etobella

Copy link
Copy Markdown
Member

@szalatyzuzanna @jelenapoblet

This PR tries to find a more "OWL" way to put all files.

Also, it splits the logic into an especific assets, simplifying the standard odoo assets

TODO: Apply the same logic to all modules.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @szalatyzuzanna,
some modules you are maintaining are being modified, check this out!

@etobella

Copy link
Copy Markdown
Member Author

By default, now it shouldn't work until we make the change to all modules...

@OCA-git-bot OCA-git-bot added the mod:barcode_stock Module barcode_stock label Nov 18, 2026
@OCA-git-bot OCA-git-bot added mod:barcode_purchase Module barcode_purchase mod:barcode_gs1 Module barcode_gs1 mod:barcode_gs1_stock Module barcode_gs1_stock labels Nov 18, 2026
@OCA-git-bot OCA-git-bot added mod:barcode_camera Module barcode_camera mod:barcode_scrap Module barcode_scrap mod:barcode_inventory Module barcode_inventory labels Nov 18, 2026
@OCA-git-bot OCA-git-bot added the mod:barcode_stock_partner_delivery_zone Module barcode_stock_partner_delivery_zone label Nov 18, 2026
@OCA-git-bot OCA-git-bot added the mod:barcode_stock_quality Module barcode_stock_quality label Nov 18, 2026
@etobella

Copy link
Copy Markdown
Member Author

@szalatyzuzanna it is green now:

What I did:

  1. I created a new asset where we define all this barcode stuff. This way, the backend does not increase unnecessarily.
  2. I reformated the structure of JS, XML and SCSS to fit in the usual OWL way:
  • static
    • components
      • component_1
        • component_1.esm.js
        • component_1.scss
        • component_1.xml
    • hooks
      • hook_1.esm.js
    • services
      • service_1.esm.js
    • utils
      • util_1.esm.js
    • tiles: I kept it as it had sense IMO
      • tile_1.esm.js

Personally, I think we should reformat scss classes too, as ilx-xxx-xxx is not how we usually do it: (o_barcode_interface_xxx maybe?). However, I would like to know your opinion before doing such a massive change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:barcode_camera Module barcode_camera mod:barcode_gs1_stock Module barcode_gs1_stock mod:barcode_gs1 Module barcode_gs1 mod:barcode_inventory Module barcode_inventory mod:barcode_purchase Module barcode_purchase mod:barcode_scanner Module barcode_scanner mod:barcode_scrap Module barcode_scrap mod:barcode_stock_partner_delivery_zone Module barcode_stock_partner_delivery_zone mod:barcode_stock_quality Module barcode_stock_quality mod:barcode_stock Module barcode_stock series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants