Skip to content

Bump pending Dependabot NuGet updates - #194

Merged
erwan-joly merged 1 commit into
masterfrom
claude/project-thread-g6srq1
Oct 31, 2026
Merged

erwan-joly merged 1 commit into
masterfrom
claude/project-thread-g6srq1

Conversation

@erwan-joly

@erwan-joly erwan-joly commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Erwan · project thread

Applies every pending Dependabot NuGet bump in one change, since the individual PRs touch adjacent lines and conflict with each other after the first one merges. Supersedes #186, #187, #190, #191, #192, #193.

  • MSTest.TestAdapter 4.4.0 → 4.5.2
  • MSTest.TestFramework 4.4.0 → 4.5.2
  • Microsoft.NET.Test.Sdk 18.10.1 → 18.11.0
  • NodaTime 3.3.3 → 3.3.7
  • NodaTime.Testing 3.3.3 → 3.3.7
  • NosCore.Packets 21.1.2 → 21.1.3

dotnet test passes locally except CheckLanguageUsage, which walks the filesystem root and hits a permission error in the sandbox; CI is the judge for that one.


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated networking and test dependencies to newer versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkWTCwfijFfjM9J7cU5
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 5af0f52 and 0e7ae71.

Files selected for processing: 2
  • src/NosCore.Networking/NosCore.Networking.csproj
  • test/NosCore.Networking.Tests/NosCore.Networking.Tests.csproj

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The production project updates NodaTime and NosCore.Packets. The test project updates Microsoft.NET.Test.Sdk, MSTest packages, and NodaTime.Testing. Moq remains unchanged.

Changes

Package version updates

Layer / File(s) Summary
Project package versions
src/NosCore.Networking/NosCore.Networking.csproj, test/NosCore.Networking.Tests/NosCore.Networking.Tests.csproj
The production project updates NodaTime and NosCore.Packets. The test project updates Microsoft.NET.Test.Sdk, MSTest.TestAdapter, MSTest.TestFramework, and NodaTime.Testing. Moq remains at 4.21.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to 0e7ae

No concrete merge-blocking issue is identified in these package updates. Merge after normal CI checks pass, including CheckLanguageUsage.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: grouping pending Dependabot NuGet dependency updates.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@erwan-joly
erwan-joly merged commit c559171 into master Oct 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants