Repository navigation
Ignore packets received after the window was closed - #130
Open
R00tB33rMan wants to merge 1 commit into
Open
R00tB33rMan wants to merge 1 commit into
R00tB33rMan wants to merge 1 commit into
Conversation
If a packet closed the window, e.g. through a click handler, the packets queued behind it in the same tick were still processed on the closed window. Clicks could then take items that a close handler had already given back.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a packet closed the window, the rest of that tick's packets were still processed on it, so clicks could take items a close handler had already given back.