Repository navigation
Don't log injection failures of closed connections - #129
Open
R00tB33rMan wants to merge 1 commit into
Open
R00tB33rMan wants to merge 1 commit into
R00tB33rMan wants to merge 1 commit into
Conversation
On Folia, PlayerJoinEvent is still called for connections that closed while the player was being placed. The pipeline of such a connection is already empty, and PlayerQuitEvent follows.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folia still calls PlayerJoinEvent for connections that already closed, so the injection failed on an empty pipeline and logged an error for a player who was already gone.