Repository navigation
Handle overlapping sessions of the same player - #128
Open
R00tB33rMan wants to merge 1 commit into
Open
R00tB33rMan wants to merge 1 commit into
R00tB33rMan wants to merge 1 commit into
Conversation
A player can rejoin before their previous session has been removed completely, e.g. on Folia. Since Player#equals only compares uuids, the old session's quit removed the new session's packet handler, the new session's join threw because a packet handler was already registered, and the old session's inventory close closed the new session's window.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player rejoins before their old session is fully removed (e.g. on Folia), Player#equals only compares uuids, so the old session's quit and inventory close hit the new session's packet handler and window.