fix(examples): ValidTarget_Right is marker 22, not 11 - #340
Merged
pellet merged 1 commit intoSep 27, 2026
Merged
Conversation
The cueing experiment writes 11/12/21/22 for Invalid/Valid x Left/Right (eegnb/experiments/visual_cueing/cueing.py). The example script and both cueing notebooks mapped ValidTarget_Right to 11, colliding with InvalidTarget_Left, so the valid-right trials (22) were never used. Current MNE rejects duplicate event_id values, which fails the docs build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cueing experiment writes markers 11/12/21/22 for Invalid/Valid x Left/Right (
eegnb/experiments/visual_cueing/cueing.py). The example script and both cueing notebooks mappedValidTarget_Rightto 11, colliding withInvalidTarget_Left, so the real valid-right trials (22) were never used.Current MNE rejects duplicate
event_idvalues, so this typo now fails the docs build.One-line change in each of:
examples/visual_cueing/01r__cueing_singlesub_analysis.pyexamples/visual_cueing/cueing.ipynbexamples/visual_cueing/CueingAnalysis_Colab.ipynb