Repository navigation
fix(openvpn): revoke road warrior certificates - #1961
Draft
gsanchietti wants to merge 3 commits into
Draft
gsanchietti wants to merge 3 commits into
gsanchietti wants to merge 3 commits into
Conversation
gsanchietti
force-pushed
the
improve_openvpn
branch
2 times, most recently
from
October 23, 2026 07:17
2a1dbb3 to
54764fc
Compare
gsanchietti
commented
Oct 23, 2026
gsanchietti
force-pushed
the
improve_openvpn
branch
from
October 23, 2026 07:21
54764fc to
0207e6c
Compare
Regenerating a road warrior certificate did not revoke the old one. Deleting a user revoked only the latest certificate, so older ones worked again once the user was added back. Revoke all valid certificates not saved inside the issued directory and update the CRL. Regeneration keeps the current certificate if the new one can't be created. Both actions close the user connection. Assisted-by: Claude Code:Opus 5.5
With certificate and credentials, a certificate issued to one user could be used with the credentials of another user. Reject the connection if the certificate CN doesn't match the user name. Assisted-by: Claude Code:Opus 5.5
Assisted-by: Claude Code:Opus 5.5
gsanchietti
force-pushed
the
improve_openvpn
branch
from
October 23, 2026 08:20
0207e6c to
11342f0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
Changes:
revoke_stale_certificates()andgenerate_crl()tonethsec.ovpn: they revoke every valid certificate not saved insidepki/issuedand update the CRL (certificate revocation list), with unit testsExisting installations
Old certificates left valid by previous releases are not revoked on upgrade. To invalidate them, use "Regenerate all certificates" on the Road Warrior server (
ns.ovpnrw regenerate-all-certificates): it creates a new CA, server and user certificates, so the new configuration must be distributed to all clients.How to test
Closes #1963
Generated by Claude Code:claude-opus-5-5 with nethserver-pr