Skip to content

fix(openvpn): ensure at least one public IP is provided and not empty - #1953

Merged
Tbaile merged 1 commit into
mainfrom
fix_drawer_defaults_public_ip
Oct 21, 2026
Merged

Tbaile merged 1 commit into
mainfrom
fix_drawer_defaults_public_ip

Conversation

@m-dilorenzi

Copy link
Copy Markdown
Collaborator

When the public IP detection failed (e.g. DNS Threat Shield blocking OpenDNS), the API returned an empty list and the UI showed no public IP field. VPN servers could also be saved without a public IP.

  • Public IP detection always returns at least one (empty) entry, so the UI always shows the field
  • OpenVPN tunnel server and Road Warrior APIs now reject a missing or empty public IP

Closes: #1951

@m-dilorenzi m-dilorenzi added this to the 8.8.1 milestone Oct 21, 2026
@m-dilorenzi
m-dilorenzi requested a review from Tbaile October 21, 2026 13:29
@m-dilorenzi m-dilorenzi self-assigned this Oct 21, 2026
@Tbaile Tbaile removed this from NethSecurity Oct 21, 2026
@Tbaile Tbaile removed this from the 8.8.1 milestone Oct 21, 2026
@Tbaile
Tbaile merged commit 27153fb into main Oct 21, 2026
9 checks passed
@Tbaile
Tbaile deleted the fix_drawer_defaults_public_ip branch October 21, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenVPN: public IP field missing when public IP detection fails

2 participants