Repository navigation
Conversation
The spec waited for running == 2 and then asserted peak == 2, but a request raises running before it records peak, so a slow runner could read peak = 1. Wait on peak instead and assert running holds at the cap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push-triggered CI run on #83 failed in
RequestThrottleSpec("permits beyond the cap wait"):only 2 may run at once, saw 1. It's a race in the test, not a throttle bug.The test waits until
running == 2and then assertspeak == 2. A request incrementsrunningbefore it updatespeak, so on a slow runner the check can happen between the two and readpeak = 1.The fix waits on
peak == 2instead, then assertsrunning == 2. That still proves the cap holds, and the later assert still checks the cap for the whole run. No production code changes.