Repository navigation
test(linux): wait for engine-side keyword delete before sending traffic - #48
Merged
Negative-Star-Innovators merged 1 commit intoOct 1, 2026
Merged
Conversation
test_keyword_delete asserted "not redacted" immediately after the GUI row disappeared, but delete_keyword's press_until predicate is panel-side and the GUI row can vanish before the engine has applied the delete — so the follow-up chat still got redacted. Same flake family as the KeyError fixed in #47, one test over: this flaked on main (build-linux x64 leg, run 36815802463, 1 failed / 20 passed). Apply the wait the regex sibling already uses: wait for the keyword to drop off the engine-side `agentredactor keywords list` before sending traffic.
Negative-Star-Innovators
deleted the
fix/atspi-keyword-delete-engine-wait
branch
October 1, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second AT-SPI flake on
main(build-linux x64 leg, run36815802463, after #47 merged):test_keyword_deletefailed withassert 'Project Chimera' in 'Mission <<REDACTED_KEYWORD_0>> today.'— 1 failed / 20 passed.Cause
test_keyword_deleteasserts "not redacted" immediately afterdelete_keyword, whosepress_untilpredicate is panel-side (text not in self.keywords()). The GUI row disappears before the engine has applied the delete, so the follow-up chat still hits the live keyword and gets redacted. (The toggle helpers don't have this gap — their predicates read engine state via the CLI.)Fix
Same wait the regex sibling (
test_regex_toggle_and_delete) already applies: afterdelete_keyword, wait for the keyword to drop off the engine-sideagentredactor keywords listbefore sending traffic. +6 lines, test-only.Note: #47's fix held — no
KeyErrorrecurrence; this is the adjacent delete path.